Re: using "bits" comparison in manpage_compare()

[Yuri Pankov <yuripv@yuripv.net>]

[-- Attachment #1.1: Type: text/plain, Size: 773 bytes --]

Yuri Pankov wrote:
> Hi,
> 
> It looks like using "bits" comparison in manpage_compare() leads to
> somewhat inconsistent output sorting for apropos(1), reported as
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227408.
> 
> So I've proposed the change below as a "fix", any thoughts on it?
> 
> Index: contrib/mandoc/mansearch.c
> ===================================================================
> --- contrib/mandoc/mansearch.c
> +++ contrib/mandoc/mansearch.c
> @@ -412,8 +412,7 @@
> 
>  	mp1 = vp1;
>  	mp2 = vp2;
> -	if ((diff = mp2->bits - mp1->bits) ||
> -	    (diff = mp1->sec - mp2->sec))
> +	if ((diff = mp1->sec - mp2->sec) != 0)
>  		return diff;
> 
>  	/* Fall back to alphabetic ordering of names. */

Any thoughts on this?


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]