From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by fantadrom.bsd.lv (OpenSMTPD) with ESMTP id 68a2fdaf for ; Wed, 21 Nov 2018 10:17:27 -0500 (EST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 2B6A621F56 for ; Wed, 21 Nov 2018 10:17:27 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 21 Nov 2018 10:17:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuripv.net; h= subject:from:to:reply-to:references:message-id:date:mime-version :in-reply-to:content-type; s=fm3; bh=bhIUs7wWWzsWvnpCHRMJ3jnhEXX 2SjQxlPCH/36MUkU=; b=gx8hw64mmlZy+gYvmkkhrEdyod4mACynkVnL9d0pp8+ w8us+DNgKfxFcs5C78XVZ4aoLpnEQSMcqLOX70/AtH4Wpoxb1m8QQK2Pjh4pJWhD G7MJe4660jpwItF3GBJY5usuvxbbTl1RE1GqTe5Ub9bqTrtxflDSyfW/Zf1+f0b3 UyZ026pG5uTNI4KWjyJo2ShNHL9xBetxsheHJFxHILK75qqR8U8poLD//SGbyp3K rmlMfLUVJogfD/a57luJdAhaxgBj/PFFaU98QQuXQFoZZ7jghiq1b1YbUaBVitEE OfObuAzOeH7TNIsAdXohAe5zRoVIYgIHXFLJ+UEimUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:reply-to:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=bhIUs7wWWzsWvnpCHRMJ3jnhEXX2SjQxlPCH/36MUkU=; b=qx9rNFWJ yeAgB9ReEAAnIDms9NcSLv8e5rUXIn+Tq0bYha7JLDeynmUhIl1QbBKAXozM6nys 3vNcUlJmsZP66CADsWbjG1HWqBumg+yxYq4pVvHOqQda5ZRzBv6sZV3Eaon4ILcl VwZ5rxauqnbmzHTM2/O/mLsbqnfOXCmHMI5ZJ9tk1W7YmLXv5Pyh5MZtGjaXk9P4 IuigdjMY7Buk8eURn/8btm1xB6HY26SbFapfviLDVY2ntn5khpGXBiuOi00401nH BS20IP9hAIJ+oEVAf11kqjyV4lo7uhyP9/xTFnrgAH3KsWEUi0xEMZUlY+JdnKU9 /vtyD7kxJs9qLw== X-ME-Sender: X-ME-Proxy: Received: from [192.168.1.2] (unknown [92.50.223.252]) by mail.messagingengine.com (Postfix) with ESMTPA id 16858E4307 for ; Wed, 21 Nov 2018 10:17:24 -0500 (EST) Subject: Re: using "bits" comparison in manpage_compare() From: Yuri Pankov To: discuss@mandoc.bsd.lv Reply-To: discuss@mandoc.bsd.lv References: Openpgp: preference=signencrypt Autocrypt: addr=yuripv@yuripv.net; keydata= xsBNBFu8u6IBCADB11gP0QwnorrHjqAtKLHKHNHskhy0s7jqJKfx0YqXgVBKGLJ9/mjLAz0F CBNvemHSDDTs0mEZ9cBKKi6cmsav6+UQgr//yai6hvXLBJqKchSFO4MhmdvBtsGFq1yKz5Zi uhjmimKyIpgBgvMdbgGbGq6cnSB2uEPmZuJr419SVRODOkXukU+F5WHgaHzDdHAIu1asCt2B +6msxqIqlFWcXyZyTGicTGGvC/PFIsVRUtD1dIJANTC876g7DTb7LZXWiWwJpSJ4GKMXMHVX Ct9BoQ4i3nhKbOxb6Io1wsy+NFyWsTJ9KYrxKKPJP3oG8BWb/cqlFqnE4eNSsiq2q7krABEB AAHNH1l1cmkgUGFua292IDx5dXJpcHZAeXVyaXB2Lm5ldD7CwJcEEwEIAEECGwMFCQWjmoAF CwkIBwMFFQoJCAsFFgMCAQACHgECF4AWIQT4arc+w94tPi0v/3CTi+B/sSrhbAUCW708wAIZ AQAKCRCTi+B/sSrhbPxBB/961alcU091O+yKT5/oReHVc/PX0Tz4sW3V44AcgLfYlrZavCro EFz90qmCrl0xqEwuAKcC4bjmL8SjPWAhSN6IH9nxdw+HeZnAPiHm/q679Bu47+nHBl3qD/9p +t1PkKeKZfaWToFMt1nq06ytSu6VLMCwLdlDNe6DReX0ex/afEqKsuaIZSKL4UYjRwklp8PU Uf98QkrfapyHB67hQMzfI4tPeJaYyv0cTgfq3kUWJx1V6Xi0b6Zxj4ZrB2TXvaMO5g7yhU9E E3WWAvoe4FgB3a7dHe8atnHhq5+Cuvm6+LD4Jh7jvMAE5UMN+xxQpnGpNghHjaCy4vXrLRBZ nhRYzsBNBFu8u6IBCADKih3Q933rDNj4ZA8FhBQ2RlmBgvwOLcDPIL3h0V7h38y3+HisgFSc XACDsdrTlYZ1bRXkD9FHENynBcv0l/3uGJDk8jaGIDE0TP8OQBRp+IaU9/BHnAqrKxTJGIol Dahy2m+yx2yhdc6B4ujWMDqCF1rWOD+ymOWw+VLllOkrHcZa5PJtX9UOGbApZl8ZTM8El4CA NN8F1bg9MWzUi+8LYoGWGc+BwsFS1OUB1c4SPgMu5fD4Wfsr9yRl06fdpEA2YT7B/j5/5RSC 0sE2Zs/tmJ/JRflHJ12ycj59ma2xQMfEJF40hZDpMFQmZvbVqgEg3ocQcltjbxlIKZ/mjC4z ABEBAAHCwHwEGAEKACYWIQT4arc+w94tPi0v/3CTi+B/sSrhbAUCW7y7ogIbDAUJBaOagAAK CRCTi+B/sSrhbIDcCACqAZMcoxUBLZa40a5b24j5i1jplvCYYb3h+Q5lt5+BFJ87kCb4dJuU D3kh2i29BrxWQWa9WNue9ozxeYkbkfXubQYXexVolRsnh64OdGsE8KvorBFBB3zdK/GRt2Jy +jsnTfUWuQllbzMP0MfhCDMk1Mo8WvDH2/cOEP/yLKf20a+cd6nLs7bidjmGXo9pyuBKAtV6 Kv+VRu54AL+A/UBYu/eB3Dtvzcnut+1Zq6KaP++kUwPwINLIk04OBDwN0zRNTiqMAFYYyz2v ZHBB6E1th/l//ZC5b9Dk0ZpFI1bYdL9ymnrZe1MqbGPnDCToQxu00T/pZCm6Z92YrZQYuNwl Message-ID: <516e2122-2c87-3a4d-c663-1b373a0898fd@yuripv.net> Date: Wed, 21 Nov 2018 18:17:16 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 X-Mailinglist: mandoc-discuss Reply-To: discuss@mandoc.bsd.lv MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pde6npeLox3MnLcUTgqzMWGSRlzXJ0U5a" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pde6npeLox3MnLcUTgqzMWGSRlzXJ0U5a Content-Type: multipart/mixed; boundary="WqWqOvSjeE6ZtvZRVaHAnLU72BUJAUaIW"; protected-headers="v1" From: Yuri Pankov Reply-To: discuss@mandoc.bsd.lv To: discuss@mandoc.bsd.lv Message-ID: <516e2122-2c87-3a4d-c663-1b373a0898fd@yuripv.net> Subject: Re: using "bits" comparison in manpage_compare() References: In-Reply-To: --WqWqOvSjeE6ZtvZRVaHAnLU72BUJAUaIW Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Yuri Pankov wrote: > Hi, >=20 > It looks like using "bits" comparison in manpage_compare() leads to > somewhat inconsistent output sorting for apropos(1), reported as > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D227408. >=20 > So I've proposed the change below as a "fix", any thoughts on it? >=20 > Index: contrib/mandoc/mansearch.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- contrib/mandoc/mansearch.c > +++ contrib/mandoc/mansearch.c > @@ -412,8 +412,7 @@ >=20 > mp1 =3D vp1; > mp2 =3D vp2; > - if ((diff =3D mp2->bits - mp1->bits) || > - (diff =3D mp1->sec - mp2->sec)) > + if ((diff =3D mp1->sec - mp2->sec) !=3D 0) > return diff; >=20 > /* Fall back to alphabetic ordering of names. */ Any thoughts on this? --WqWqOvSjeE6ZtvZRVaHAnLU72BUJAUaIW-- --pde6npeLox3MnLcUTgqzMWGSRlzXJ0U5a Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Gq3PsPeLT4tL/9wk4vgf7Eq4WwFAlv1dwMACgkQk4vgf7Eq 4WwQCAf9HGSuw2GMOfkUyusWisCEZ2A2NdISZFKlG6rPdasVJNgduLn7LI32qg1j FQzHklhpiMiaTGK3ozRplTAFN8qfABKMPt3np29XO3hjhll3VsJXWFkId2Dfi6ZV 2RawWPZxMff0v3h0fiBb/80uXooYc43/ZLrIXLnx39wOdjpyzXVLu1k6ZNRKde3Y n8iZGRetW5Z9U21NbLD+SsLzEpv+dA3t7hLlZ9JnCESGFSmyWDIk2ZuNUZ/z7V8h hp0v3lcbGwcKPOucyO3jfwGXah3LB28jEldHkNOdGePxVQ/I/Wr6XCydfS49Nr92 l8JVdE/sqt8VnEone2FUA/IvFJsWbA== =gVzD -----END PGP SIGNATURE----- --pde6npeLox3MnLcUTgqzMWGSRlzXJ0U5a-- -- To unsubscribe send an email to discuss+unsubscribe@mandoc.bsd.lv