From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from nm14-vm0.bullet.mail.bf1.yahoo.com (nm14-vm0.bullet.mail.bf1.yahoo.com [98.139.213.164]) by fantadrom.bsd.lv (OpenSMTPD) with ESMTP id 907b3229 for ; Fri, 6 Nov 2015 22:01:13 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com.au; s=s2048; t=1446865270; bh=8bpIFJtDJov98quPX93kRXR5vdWPTATEZU3DuW6AK+k=; h=Date:From:To:Subject:From:Subject; b=k0RRrixzYjVNjhM5meGSJ6d22/q7t+L289wBQcyje5htNxVRaX4gZP1idOffwunYbESUEp0EhHX1P7BFhiGePnY7IMCgZlZ1GzfCsJ+5D+IJ7mD2xhkOH5qIuMMC/b6fLJCjb8swisKtGhHOO3grsVw9cc3ldljK+zCvtxAo12kP2zQ0gbGxan0u7gS57uH9RLYd3md5wbJox4ew+Ljx5WqkOdHz09XciTU6JvScJ0nvS5OOENlL8+Y/rQtKuJ2qg2/LIb0yMppAs+J7FfUrbHSb8aZVPQUpYgbSRR2MrFVLt/5mtnFFpDOIDaCuqlxa5MMfhUZqYOLLyr3E/9MZVA== Received: from [66.196.81.171] by nm14.bullet.mail.bf1.yahoo.com with NNFMP; 07 Nov 2015 03:01:10 -0000 Received: from [98.139.211.194] by tm17.bullet.mail.bf1.yahoo.com with NNFMP; 07 Nov 2015 03:01:10 -0000 Received: from [127.0.0.1] by smtp203.mail.bf1.yahoo.com with NNFMP; 07 Nov 2015 03:01:10 -0000 X-Yahoo-Newman-Id: 685644.16694.bm@smtp203.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 1QbyP44VM1l_KvoNksMBKZGXHRcMWG3MQZfyHJSXyPYLgI9 jyS6KritXXZtU.EBXqP5GkeXXmBXtYuHMH7.y4F.LnfRX_rH5HkK4jus71Pf TkIr7Jb1nqSHk6_REtZ3CkXJJpEMEQ3HL7xzfrWcTcyfAp3wR4s26blDRDwc wrQMjkskCrJ88xCICLwKMwVgnqqzs3Q9g3B6aXFK9mpUso5Gf0_q3ikmR4zi Df3qC.LSTZqrezlfl.Ol822GNTOvnYan5Cg9_bCTKvoBbvbCmCMQ8Oj57.lx dsQ_yKEBDBPoWWsSKpNQWST09VUca5Hl.ptsCDnNVLr_wA7zjKoeZeQVLFK8 F0Yr2LEQfELVV5e8TiBEneJx_DGiIZkgVclVqKHfc8BNw.PNqltM3U2popW6 tKk8ImG1jiRbkxIYOe8GH_CedlOXhLCc47C4Li0t41PL7UkXSXZVOq29J6fv TaK5h0fp0pT2ZyNxFXLJQ1E5Ru2Vt4OaEalRYqaXnChUEf5mRj.DYhjQVupZ ZEdidTMoEWEN6FCgwyxi.qClvx2TknPY- X-Yahoo-SMTP: wy_7AdSswBBaijFlmVnVzTL.0g-- Message-ID: <563D6968.8020401@yahoo.com.au> Date: Sat, 07 Nov 2015 14:00:56 +1100 From: Peter Bray User-Agent: Mozilla/5.0 (X11; SunOS i86pc; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 X-Mailinglist: mdocml-discuss Reply-To: discuss@mdocml.bsd.lv MIME-Version: 1.0 To: discuss@mdocml.bsd.lv Subject: mdocml [CVS_2015_11_07] Code needs HAVE_ERR guards Content-Type: multipart/mixed; boundary="------------050403050808020109030807" This is a multi-part message in MIME format. --------------050403050808020109030807 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Greetings, Ingo has posted a patch to regarding mandoc whatis(1): autodetect RE syntax for word boundaries So I thought I would try compiling mdocml_cvs on Solaris 10 and 11 again. The "configure" script checks for the presence of "err.h", setting HAVE_ERR to 0 or 1 based on the check result. Unlike the HAVE_FTS check the, code that uses '#include ' does not wrap this preprocessor directive in a guard. Two possible simple solutions exist (based on what I have seen so far). 1. Wrap the include directive in a simple '#if HAVE_ERR' and '#endif'. Patch included. 2. Take the HAVE_FTS approach and move the declarations from the generated config.h to compat_err.h and like fts.h, use a conditional of the form: #if HAVE_ERR # include #else # include "compat_err.h" #fi I'll leave it to the developers and maintainers to choose the appropriate solution for their code base. Regards, Peter Bray Sydney, Australia PS: Discovered on Solaris 10 which does not have --------------050403050808020109030807 Content-Type: text/plain; charset=ISO-8859-1; name="mdocml_cvs_2015_11_07-HAVE_ERR-guards.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="mdocml_cvs_2015_11_07-HAVE_ERR-guards.diff" diff -r -U 2 mdocml-cvs_2015_11_07.orig/compat_err.c mdocml-cvs_2015_11_07/compat_err.c --- mdocml-cvs_2015_11_07.orig/compat_err.c 2015-11-06 16:30:33.000000000 +0000 +++ mdocml-cvs_2015_11_07/compat_err.c 2015-11-07 02:40:13.751774337 +0000 @@ -37,5 +37,7 @@ */ +#if HAVE_ERR #include +#endif #include #include Only in mdocml-cvs_2015_11_07: compat_err.c.orig diff -r -U 2 mdocml-cvs_2015_11_07.orig/compat_stringlist.c mdocml-cvs_2015_11_07/compat_stringlist.c --- mdocml-cvs_2015_11_07.orig/compat_stringlist.c 2015-05-21 00:13:43.000000000 +0000 +++ mdocml-cvs_2015_11_07/compat_stringlist.c 2015-11-07 02:40:13.757923786 +0000 @@ -34,5 +34,7 @@ */ +#if HAVE_ERR #include +#endif #include #include Only in mdocml-cvs_2015_11_07: compat_stringlist.c.orig diff -r -U 2 mdocml-cvs_2015_11_07.orig/main.c mdocml-cvs_2015_11_07/main.c --- mdocml-cvs_2015_11_07.orig/main.c 2015-11-07 00:47:44.000000000 +0000 +++ mdocml-cvs_2015_11_07/main.c 2015-11-07 02:40:13.764627128 +0000 @@ -25,5 +25,7 @@ #include #include +#if HAVE_ERR #include +#endif #include #include Only in mdocml-cvs_2015_11_07: main.c.orig diff -r -U 2 mdocml-cvs_2015_11_07.orig/mandoc_aux.c mdocml-cvs_2015_11_07/mandoc_aux.c --- mdocml-cvs_2015_11_07.orig/mandoc_aux.c 2015-11-07 00:47:44.000000000 +0000 +++ mdocml-cvs_2015_11_07/mandoc_aux.c 2015-11-07 02:40:13.770768706 +0000 @@ -20,5 +20,7 @@ #include +#if HAVE_ERR #include +#endif #include #include Only in mdocml-cvs_2015_11_07: mandoc_aux.c.orig diff -r -U 2 mdocml-cvs_2015_11_07.orig/mandocdb.c mdocml-cvs_2015_11_07/mandocdb.c --- mdocml-cvs_2015_11_07.orig/mandocdb.c 2015-11-07 00:47:44.000000000 +0000 +++ mdocml-cvs_2015_11_07/mandocdb.c 2015-11-07 02:40:13.778167590 +0000 @@ -24,5 +24,7 @@ #include #include +#if HAVE_ERR #include +#endif #include #include Only in mdocml-cvs_2015_11_07: mandocdb.c.orig diff -r -U 2 mdocml-cvs_2015_11_07.orig/manpath.c mdocml-cvs_2015_11_07/manpath.c --- mdocml-cvs_2015_11_07.orig/manpath.c 2015-11-07 00:47:44.000000000 +0000 +++ mdocml-cvs_2015_11_07/manpath.c 2015-11-07 02:40:13.784549032 +0000 @@ -22,5 +22,7 @@ #include +#if HAVE_ERR #include +#endif #include #include Only in mdocml-cvs_2015_11_07: manpath.c.orig diff -r -U 2 mdocml-cvs_2015_11_07.orig/mansearch.c mdocml-cvs_2015_11_07/mansearch.c --- mdocml-cvs_2015_11_07.orig/mansearch.c 2015-11-07 00:47:44.000000000 +0000 +++ mdocml-cvs_2015_11_07/mansearch.c 2015-11-07 02:40:13.791014961 +0000 @@ -22,5 +22,7 @@ #include +#if HAVE_ERR #include +#endif #include #include Only in mdocml-cvs_2015_11_07: mansearch.c.orig diff -r -U 2 mdocml-cvs_2015_11_07.orig/read.c mdocml-cvs_2015_11_07/read.c --- mdocml-cvs_2015_11_07.orig/read.c 2015-11-07 00:47:45.000000000 +0000 +++ mdocml-cvs_2015_11_07/read.c 2015-11-07 02:40:13.797540657 +0000 @@ -27,5 +27,7 @@ #include #include +#if HAVE_ERR #include +#endif #include #include Only in mdocml-cvs_2015_11_07: read.c.orig diff -r -U 2 mdocml-cvs_2015_11_07.orig/soelim.c mdocml-cvs_2015_11_07/soelim.c --- mdocml-cvs_2015_11_07.orig/soelim.c 2015-05-21 00:18:52.000000000 +0000 +++ mdocml-cvs_2015_11_07/soelim.c 2015-11-07 02:40:13.803657540 +0000 @@ -30,5 +30,7 @@ #include +#if HAVE_ERR #include +#endif #include #include Only in mdocml-cvs_2015_11_07: soelim.c.orig diff -r -U 2 mdocml-cvs_2015_11_07.orig/term_ps.c mdocml-cvs_2015_11_07/term_ps.c --- mdocml-cvs_2015_11_07.orig/term_ps.c 2015-11-07 00:47:45.000000000 +0000 +++ mdocml-cvs_2015_11_07/term_ps.c 2015-11-07 02:40:13.810363973 +0000 @@ -21,5 +21,7 @@ #include +#if HAVE_ERR #include +#endif #include #include Only in mdocml-cvs_2015_11_07: term_ps.c.orig diff -r -U 2 mdocml-cvs_2015_11_07.orig/test-err.c mdocml-cvs_2015_11_07/test-err.c --- mdocml-cvs_2015_11_07.orig/test-err.c 2015-10-11 21:12:55.000000000 +0000 +++ mdocml-cvs_2015_11_07/test-err.c 2015-11-07 02:40:13.816369014 +0000 @@ -16,5 +16,7 @@ */ +#if HAVE_ERR #include +#endif int Only in mdocml-cvs_2015_11_07: test-err.c.orig --------------050403050808020109030807-- -- To unsubscribe send an email to discuss+unsubscribe@mdocml.bsd.lv