Re: mdocml [CVS_2015_11_07] Code needs HAVE_ERR guards

[Peter Bray <pdb_ml@yahoo.com.au>]

All,

Sorry for following up to my own post, but the patch provided included a 
redundant automated edit (I used perl(1) to edit the code for the patch).

Regardless of the solution chosen, 'compat_err.c' should not be 
including <err.h> as we already know we don't have it, because of the 
larger cpp(1) guards (#if HAVE_ERR) around the code.

If using solution 1, delete the '#include <err.h>'
If using solution 2, change the '#include <err.h>' to '#include 
"compat_err.h"'

Regards,

Peter


On  7/11/15 02:00 PM, Peter Bray wrote:
> Greetings,
>
> Ingo has posted a patch to regarding
>
>      mandoc whatis(1): autodetect RE syntax for word boundaries
>
> So I thought I would try compiling mdocml_cvs on Solaris 10 and 11 again.
>
> The "configure" script checks for the presence of "err.h", setting
> HAVE_ERR to 0 or 1 based on the check result.
>
> Unlike the HAVE_FTS check the, code that uses '#include <err.h>' does
> not wrap this preprocessor directive in a guard.
>
> Two possible simple solutions exist (based on what I have seen so far).
>
> 1. Wrap the include directive in a simple '#if HAVE_ERR' and '#endif'.
>     Patch included.
>
> 2. Take the HAVE_FTS approach and move the declarations from the generated
>     config.h to compat_err.h and like fts.h, use a conditional of the form:
>
> #if HAVE_ERR
> #  include <err.h>
> #else
> #  include "compat_err.h"
> #fi
>
> I'll leave it to the developers and maintainers to choose the
> appropriate solution for their code base.
>
> Regards,
>
> Peter Bray
> Sydney, Australia
>
> PS: Discovered on Solaris 10 which does not have <err.h>

--
 To unsubscribe send an email to discuss+unsubscribe@mdocml.bsd.lv