From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from nm5-vm0.bullet.mail.bf1.yahoo.com (nm5-vm0.bullet.mail.bf1.yahoo.com [98.139.213.150]) by fantadrom.bsd.lv (OpenSMTPD) with ESMTP id 53f14067 for ; Fri, 6 Nov 2015 23:14:29 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com.au; s=s2048; t=1446869668; bh=MRidVNiNV1NeAsMU+Bzta9L238c1vBhCqjf9qUPPGt8=; h=Date:From:Reply-To:To:Subject:References:In-Reply-To:From:Subject; b=W3eskY1w6TqPYFdtQQ7/olZTCO2mjnGSs9BIe0MN2ggAz0KI35Ag6A3t1QdQECCbbq1KmZp2hj3lL+mD+m/dZKzfhXqTVtR0/TwcXTvgXXU3uZDcCd54faDVlrcQDAUhz+e+terUtgWyJCboKRXB6XNmHNKTvvDyWYiMmYKgofUHs+mSD0oosPS5CDj20yvaWOnBXlScj3GOs9HfufEpz7YOxlPmv3par6Vyhc/uc5KXRyNE/52JqttRrbDgz6mquNxDf3wXnHgISQsKhTRRVLrqFq1TkA+WtLzUniq9wp3CwsRoDeQbHdXUrkg1J8iqArRGlqlQvLo2OkuNnuSF6w== Received: from [98.139.215.142] by nm5.bullet.mail.bf1.yahoo.com with NNFMP; 07 Nov 2015 04:14:28 -0000 Received: from [98.139.211.192] by tm13.bullet.mail.bf1.yahoo.com with NNFMP; 07 Nov 2015 04:14:28 -0000 Received: from [127.0.0.1] by smtp201.mail.bf1.yahoo.com with NNFMP; 07 Nov 2015 04:14:28 -0000 X-Yahoo-Newman-Id: 410761.96869.bm@smtp201.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 595kvacVM1kYSym5fnOQKy.suM9hcIkwLEP8l7gpo0qJnL. JhKhx3oJEcAiifr5oZtM5RVmFZyJ4FQKnMwKqLsYzgOm6Xti6naFAhtOV7B8 1hB_GzSrhA_cd6n6Fbrpyy8hszwO_YSlnTEtefkjWs434ipN6L4qXqT1b8jb g.7tdgtfBsjpqyHBsoJTGrfcKineP6v96o1UapeM5XkiCI3ml8cxd16aUBr9 uowneZ3Tyoq.6CkSwZYXxjtBBWFsy6G6809dE0WDfJC8h.eNs9Ybmxek8hMt XqXLcF8U5ggFr7ED6WS9g2mYt5JrqJQys_pFPavfTBihy4uVVuIUiEkRBFol 0OnUUKhQhe9U9c2vgW3z8fz.U9.XLX9ZEZjYCwdzbus9ZH.e4uvzPNUBzL0v VOnXQCK3mWwLTeEKbSg0IZcnP5fhKy._loQ5bNoG1BYTqiMjjgisv0lXPcy1 SI53UYMvVMM4Y8T_z1U3lEUQgmk58vxRpikbEVbVtvPZqaUliAELu9HA0vsd Vz2D7plKeYaQIUuUb80YaPd6d16YmHYY- X-Yahoo-SMTP: wy_7AdSswBBaijFlmVnVzTL.0g-- Message-ID: <563D7AA2.40306@yahoo.com.au> Date: Sat, 07 Nov 2015 15:14:26 +1100 From: Peter Bray Reply-To: discuss@mdocml.bsd.lv User-Agent: Mozilla/5.0 (X11; SunOS i86pc; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 X-Mailinglist: mdocml-discuss Reply-To: discuss@mdocml.bsd.lv MIME-Version: 1.0 To: discuss@mdocml.bsd.lv Subject: Re: mdocml [CVS_2015_11_07] Code needs HAVE_ERR guards References: <563D6968.8020401@yahoo.com.au> In-Reply-To: <563D6968.8020401@yahoo.com.au> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit All, Sorry for following up to my own post, but the patch provided included a redundant automated edit (I used perl(1) to edit the code for the patch). Regardless of the solution chosen, 'compat_err.c' should not be including as we already know we don't have it, because of the larger cpp(1) guards (#if HAVE_ERR) around the code. If using solution 1, delete the '#include ' If using solution 2, change the '#include ' to '#include "compat_err.h"' Regards, Peter On 7/11/15 02:00 PM, Peter Bray wrote: > Greetings, > > Ingo has posted a patch to regarding > > mandoc whatis(1): autodetect RE syntax for word boundaries > > So I thought I would try compiling mdocml_cvs on Solaris 10 and 11 again. > > The "configure" script checks for the presence of "err.h", setting > HAVE_ERR to 0 or 1 based on the check result. > > Unlike the HAVE_FTS check the, code that uses '#include ' does > not wrap this preprocessor directive in a guard. > > Two possible simple solutions exist (based on what I have seen so far). > > 1. Wrap the include directive in a simple '#if HAVE_ERR' and '#endif'. > Patch included. > > 2. Take the HAVE_FTS approach and move the declarations from the generated > config.h to compat_err.h and like fts.h, use a conditional of the form: > > #if HAVE_ERR > # include > #else > # include "compat_err.h" > #fi > > I'll leave it to the developers and maintainers to choose the > appropriate solution for their code base. > > Regards, > > Peter Bray > Sydney, Australia > > PS: Discovered on Solaris 10 which does not have -- To unsubscribe send an email to discuss+unsubscribe@mdocml.bsd.lv