From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by fantadrom.bsd.lv (OpenSMTPD) with ESMTP id 35e7d228 for ; Mon, 29 Oct 2018 17:41:27 -0500 (EST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 8EDB4222BD for ; Mon, 29 Oct 2018 18:41:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 29 Oct 2018 18:41:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuripv.net; h=to :from:subject:message-id:date:mime-version:content-type :content-transfer-encoding; s=fm3; bh=/OI4zgCFp/g5y6F3ar4owAWCFQ f9QQc9KDbiwIszFns=; b=JNTglLfpdcgXF73LCm5VInNeEEK+uF+S9alaDXJjOQ eow/qZtr50SNk05Zp63zjzDM845pYmWaK58PNdOTAQf/WHLk8cdJaCMTQ+Lac0Cv HqI8un8+uDWFaqgBf0/nq+L5IwWg4R9st2VApp+vkmP5VUpFKAPGLjH1XZqspsIM ibibixIzQdB2qO7Aa0hT+c+91MBr0F42PO28EW2Ho+vIic5WaB0of++vMqir30TT 9bkvzZ7CGGI14uUcnKmyD34QCYnty4SHUz3XFcbuHQygSyCYaxYTzw0Bqo8gL5Dh 6QdFEJzX4+AFexAe84LWimWIgzyc+Hiat8VSkkRuHLuw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=/OI4zg CFp/g5y6F3ar4owAWCFQf9QQc9KDbiwIszFns=; b=F27lCj8B9mObR8CNWSgKQ/ jkuE3cs9byLNyfGKCc5iyWV6/tz0DZWNZD9k/fp4b4TraMmeTX1w+rcMJzYP2Vnd 9oXfEh5rpvzGLcIMBc0dk+dTa48wW7PNx0JKOoh3bSlDHiuVkJ204WQ+RxEgA5w5 jo8LrJxjxeVk+7sThqtDXqQGGvPd/mGt3LdCYd4N09WWNK0h1dceUYQzJVuc+VF3 XG38LD9O/sQd7WYbU4uzStXZOp8ycDiP/djMr9dI7WbIZUGscG37tima4zmIK5Ga xPqAlGRMzNctnv295wnL/Hg+TNgo0DV+WxZ13JhPuTDshwF7i/kSJjPsnNd9g43g == X-ME-Sender: X-ME-Proxy: Received: from [192.168.1.2] (unknown [62.183.125.207]) by mail.messagingengine.com (Postfix) with ESMTPA id E1C5AE4893 for ; Mon, 29 Oct 2018 18:41:24 -0400 (EDT) To: discuss@mandoc.bsd.lv From: Yuri Pankov Subject: using "bits" comparison in manpage_compare() Openpgp: preference=signencrypt Autocrypt: addr=yuripv@yuripv.net; keydata= xsBNBFu8u6IBCADB11gP0QwnorrHjqAtKLHKHNHskhy0s7jqJKfx0YqXgVBKGLJ9/mjLAz0F CBNvemHSDDTs0mEZ9cBKKi6cmsav6+UQgr//yai6hvXLBJqKchSFO4MhmdvBtsGFq1yKz5Zi uhjmimKyIpgBgvMdbgGbGq6cnSB2uEPmZuJr419SVRODOkXukU+F5WHgaHzDdHAIu1asCt2B +6msxqIqlFWcXyZyTGicTGGvC/PFIsVRUtD1dIJANTC876g7DTb7LZXWiWwJpSJ4GKMXMHVX Ct9BoQ4i3nhKbOxb6Io1wsy+NFyWsTJ9KYrxKKPJP3oG8BWb/cqlFqnE4eNSsiq2q7krABEB AAHNIFl1cmkgUGFua292IDx5dXJpcHZARnJlZUJTRC5vcmc+wsCUBBMBCgA+FiEE+Gq3PsPe LT4tL/9wk4vgf7Eq4WwFAlu9Cn0CGwMFCQWjmoAFCwkIBwMFFQoJCAsFFgMCAQACHgECF4AA CgkQk4vgf7Eq4WxuPQf9HccaDyusO1J+wDQNlp9/uU0cnIfjHAeG80xrAfN9Vnf1wO9T2/WI iYlIdK+KVnhSa/DeBuHq/asfpUbrOleTF0hzG39os+95DzuT9a/j5XeQGuBgNbpVB+10zR3I 5AagSQetHilcZtz65g9GTUuIxb+xDaBehFBjyYXApfNE6yY5IlzDZpM7MOOLLFm2mQwQ8yjS eZ4jA6qW6/QMXRTkmpC9EXIeWDuNgWBwszaFGR6oUIpl0mGmwdJkEKwUazt6OuoDilMNZefZ 0pVFZBhnE46vK+6FDDFZE3BkeHVnqvy2QGL/6uKhSHc0lChCEPHnhqz6v23MwcQ6ktVWzvBJ oM7ATQRbvLuiAQgAyood0Pd96wzY+GQPBYQUNkZZgYL8Di3AzyC94dFe4d/Mt/h4rIBUnFwA g7Ha05WGdW0V5A/RRxDcpwXL9Jf97hiQ5PI2hiAxNEz/DkAUafiGlPfwR5wKqysUyRiKJQ2o ctpvssdsoXXOgeLo1jA6ghda1jg/spjlsPlS5ZTpKx3GWuTybV/VDhmwKWZfGUzPBJeAgDTf BdW4PTFs1IvvC2KBlhnPgcLBUtTlAdXOEj4DLuXw+Fn7K/ckZdOn3aRANmE+wf4+f+UUgtLB NmbP7ZifyUX5RyddsnI+fZmtsUDHxCReNIWQ6TBUJmb21aoBIN6HEHJbY28ZSCmf5owuMwAR AQABwsB8BBgBCgAmFiEE+Gq3PsPeLT4tL/9wk4vgf7Eq4WwFAlu8u6ICGwwFCQWjmoAACgkQ k4vgf7Eq4WyA3AgAqgGTHKMVAS2WuNGuW9uI+YtY6ZbwmGG94fkOZbefgRSfO5Am+HSblA95 IdotvQa8VkFmvVjbnvaM8XmJG5H17m0GF3sVaJUbJ4euDnRrBPCr6KwRQQd83Svxkbdicvo7 J031FrkJZW8zD9DH4QgzJNTKPFrwx9v3DhD/8iyn9tGvnHepy7O24nY5hl6PacrgSgLVeir/ lUbueAC/gP1AWLv3gdw7b83J7rftWauimj/vpFMD8CDSyJNODgQ8DdM0TU4qjABWGMs9r2Rw QehNbYf5f/2QuW/Q5NGaRSNW2HS/cpp62XtTKmxj5wwk6EMbtNE/6WQpumfdmK2UGLjcJQ== Message-ID: Date: Tue, 30 Oct 2018 01:41:23 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 X-Mailinglist: mandoc-discuss Reply-To: discuss@mandoc.bsd.lv MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, It looks like using "bits" comparison in manpage_compare() leads to somewhat inconsistent output sorting for apropos(1), reported as https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227408. So I've proposed the change below as a "fix", any thoughts on it? Index: contrib/mandoc/mansearch.c =================================================================== --- contrib/mandoc/mansearch.c +++ contrib/mandoc/mansearch.c @@ -412,8 +412,7 @@ mp1 = vp1; mp2 = vp2; - if ((diff = mp2->bits - mp1->bits) || - (diff = mp1->sec - mp2->sec)) + if ((diff = mp1->sec - mp2->sec) != 0) return diff; /* Fall back to alphabetic ordering of names. */ -- To unsubscribe send an email to discuss+unsubscribe@mandoc.bsd.lv