* mdocml: mdoc_valid_post() may indirectly call roff_node_unlink() which
@ 2015-05-01 16:59 schwarze
0 siblings, 0 replies; only message in thread
From: schwarze @ 2015-05-01 16:59 UTC (permalink / raw)
To: source
Log Message:
-----------
mdoc_valid_post() may indirectly call roff_node_unlink() which may
set ROFF_NEXT_CHILD, which is desirable for the final call to
mdoc_valid_post() - in case the target itself gets deleted, the
parse point may need this adjustment - but not for the intermediate
calls - if intermediate nodes get deleted, that mustn't clobber the
parse point. So move setting ROFF_NEXT_SIBLING to the proper place
in rew_last().
This fixes the assertion failure in jsg@'s afl test case 108/Apr27.
Modified Files:
--------------
mdocml:
mdoc_macro.c
Revision Data
-------------
Index: mdoc_macro.c
===================================================================
RCS file: /home/cvs/mdocml/mdocml/mdoc_macro.c,v
retrieving revision 1.199
retrieving revision 1.200
diff -Lmdoc_macro.c -Lmdoc_macro.c -u -p -r1.199 -r1.200
--- mdoc_macro.c
+++ mdoc_macro.c
@@ -263,7 +263,6 @@ rew_last(struct roff_man *mdoc, const st
if (to->flags & MDOC_VALID)
return;
- mdoc->next = ROFF_NEXT_SIBLING;
while (mdoc->last != to) {
/*
* Save the parent here, because we may delete the
@@ -276,6 +275,7 @@ rew_last(struct roff_man *mdoc, const st
mdoc->last = np;
assert(mdoc->last);
}
+ mdoc->next = ROFF_NEXT_SIBLING;
mdoc_valid_post(mdoc);
}
--
To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-05-01 16:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-01 16:59 mdocml: mdoc_valid_post() may indirectly call roff_node_unlink() which schwarze
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).