From: schwarze@mdocml.bsd.lv
To: source@mdocml.bsd.lv
Subject: mdocml: fix integer overflows by using reallocarray(3)
Date: Wed, 20 May 2015 18:01:14 -0500 (EST) [thread overview]
Message-ID: <12422132744729570443.enqueue@fantadrom.bsd.lv> (raw)
Log Message:
-----------
fix integer overflows by using reallocarray(3)
Modified Files:
--------------
mdocml:
compat_stringlist.c
Revision Data
-------------
Index: compat_stringlist.c
===================================================================
RCS file: /home/cvs/mdocml/mdocml/compat_stringlist.c,v
retrieving revision 1.2
retrieving revision 1.3
diff -Lcompat_stringlist.c -Lcompat_stringlist.c -u -p -r1.2 -r1.3
--- compat_stringlist.c
+++ compat_stringlist.c
@@ -48,7 +48,7 @@ sl_init(void)
sl->sl_cur = 0;
sl->sl_max = _SL_CHUNKSIZE;
- sl->sl_str = malloc(sl->sl_max * sizeof(char *));
+ sl->sl_str = reallocarray(NULL, sl->sl_max, sizeof(char *));
if (sl->sl_str == NULL)
err(1, "stringlist");
return sl;
@@ -63,7 +63,8 @@ sl_add(StringList *sl, char *name)
{
if (sl->sl_cur == sl->sl_max - 1) {
sl->sl_max += _SL_CHUNKSIZE;
- sl->sl_str = reallocf(sl->sl_str, sl->sl_max * sizeof(char *));
+ sl->sl_str = reallocarray(sl->sl_str,
+ sl->sl_max, sizeof(char *));
if (sl->sl_str == NULL)
return (-1);
}
--
To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv
reply other threads:[~2015-05-20 23:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12422132744729570443.enqueue@fantadrom.bsd.lv \
--to=schwarze@mdocml.bsd.lv \
--cc=source@mdocml.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).