From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from localhost (fantadrom.bsd.lv [local]);
	by fantadrom.bsd.lv (OpenSMTPD) with ESMTPA id c5b1ff29;
	for <source@mdocml.bsd.lv>;
	Wed, 20 May 2015 18:01:14 -0500 (EST)
Date: Wed, 20 May 2015 18:01:14 -0500 (EST)
Message-Id: <12422132744729570443.enqueue@fantadrom.bsd.lv>
X-Mailinglist: mdocml-source
Reply-To: source@mdocml.bsd.lv
MIME-Version: 1.0
From: schwarze@mdocml.bsd.lv
To: source@mdocml.bsd.lv
Subject: mdocml: fix integer overflows by using reallocarray(3)
X-Mailer: activitymail 1.26, http://search.cpan.org/dist/activitymail/
Content-Type: text/plain; charset=utf-8

Log Message:
-----------
fix integer overflows by using reallocarray(3)

Modified Files:
--------------
    mdocml:
        compat_stringlist.c

Revision Data
-------------
Index: compat_stringlist.c
===================================================================
RCS file: /home/cvs/mdocml/mdocml/compat_stringlist.c,v
retrieving revision 1.2
retrieving revision 1.3
diff -Lcompat_stringlist.c -Lcompat_stringlist.c -u -p -r1.2 -r1.3
--- compat_stringlist.c
+++ compat_stringlist.c
@@ -48,7 +48,7 @@ sl_init(void)
 
 	sl->sl_cur = 0;
 	sl->sl_max = _SL_CHUNKSIZE;
-	sl->sl_str = malloc(sl->sl_max * sizeof(char *));
+	sl->sl_str = reallocarray(NULL, sl->sl_max, sizeof(char *));
 	if (sl->sl_str == NULL)
 		err(1, "stringlist");
 	return sl;
@@ -63,7 +63,8 @@ sl_add(StringList *sl, char *name)
 {
 	if (sl->sl_cur == sl->sl_max - 1) {
 		sl->sl_max += _SL_CHUNKSIZE;
-		sl->sl_str = reallocf(sl->sl_str, sl->sl_max * sizeof(char *));
+		sl->sl_str = reallocarray(sl->sl_str,
+		    sl->sl_max, sizeof(char *));
 		if (sl->sl_str == NULL)
 			return (-1);
 	}
--
 To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv