From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from localhost (fantadrom.bsd.lv [local]); by fantadrom.bsd.lv (OpenSMTPD) with ESMTPA id 8c97ec08; for ; Thu, 12 Mar 2015 19:20:11 -0500 (EST) Date: Thu, 12 Mar 2015 19:20:11 -0500 (EST) Message-Id: <12624532129193710670.enqueue@fantadrom.bsd.lv> X-Mailinglist: mdocml-source Reply-To: source@mdocml.bsd.lv MIME-Version: 1.0 From: schwarze@mdocml.bsd.lv To: source@mdocml.bsd.lv Subject: mdocml: Fix hardlink detection on platforms having padding in struct X-Mailer: activitymail 1.26, http://search.cpan.org/dist/activitymail/ Content-Type: text/plain; charset=utf-8 Log Message: ----------- Fix hardlink detection on platforms having padding in struct inodev, typically 64bit platforms. This was basically broken since forever. Not only is the padding used, but it was used uninitialized. Problem reported by jmc@. Modified Files: -------------- mdocml: mandocdb.c Revision Data ------------- Index: mandocdb.c =================================================================== RCS file: /home/cvs/mdocml/mdocml/mandocdb.c,v retrieving revision 1.185 retrieving revision 1.186 diff -Lmandocdb.c -Lmandocdb.c -u -p -r1.185 -r1.186 --- mandocdb.c +++ mandocdb.c @@ -942,6 +942,7 @@ mlink_add(struct mlink *mlink, const str assert(NULL == ohash_find(&mlinks, slot)); ohash_insert(&mlinks, slot, mlink); + memset(&inodev, 0, sizeof(inodev)); /* Clear padding. */ inodev.st_ino = st->st_ino; inodev.st_dev = st->st_dev; slot = ohash_lookup_memory(&mpages, (char *)&inodev, -- To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv