source@mandoc.bsd.lv
 help / color / mirror / Atom feed
* mdocml: The root of an .EQ tree is always EQN_ROOT, never EQN_LIST, so
@ 2016-01-08  0:51 schwarze
  0 siblings, 0 replies; only message in thread
From: schwarze @ 2016-01-08  0:51 UTC (permalink / raw)
  To: source

Log Message:
-----------
The root of an .EQ tree is always EQN_ROOT, never EQN_LIST,
so delete a redundant NULL check that confused Coverity in CID 1257471;
issue reported by wiz@, patch differs from what christos@ did in NetBSD.
No functional change.

Modified Files:
--------------
    mdocml:
        eqn.c

Revision Data
-------------
Index: eqn.c
===================================================================
RCS file: /home/cvs/mdocml/mdocml/eqn.c,v
retrieving revision 1.60
retrieving revision 1.61
diff -Leqn.c -Leqn.c -u -p -r1.60 -r1.61
--- eqn.c
+++ eqn.c
@@ -987,7 +987,7 @@ this_tok:
 				parent->right = mandoc_strndup(start, sz);
 		}
 		parent = parent->parent;
-		if (EQN_TOK_BRACE_CLOSE == tok && parent &&
+		if (tok == EQN_TOK_BRACE_CLOSE &&
 		    (parent->type == EQN_PILE ||
 		     parent->type == EQN_MATRIX))
 			parent = parent->parent;
--
 To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-01-08  0:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-08  0:51 mdocml: The root of an .EQ tree is always EQN_ROOT, never EQN_LIST, so schwarze

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).