source@mandoc.bsd.lv
 help / color / mirror / Atom feed
* mdocml: The code already pays attention not to close the same block
@ 2014-12-22 23:28 schwarze
  0 siblings, 0 replies; only message in thread
From: schwarze @ 2014-12-22 23:28 UTC (permalink / raw)
  To: source

Log Message:
-----------
The code already pays attention not to close the same block twice.
Similarly, avoid having the same block break two other blocks.
In some situations, this could lead to an endless loop in rew_sub() 
found by jsg@ with afl.  
Minimal example:  .Po Ao Pc Bo Pc Ac Bc

Modified Files:
--------------
    mdocml:
        mdoc_macro.c

Revision Data
-------------
Index: mdoc_macro.c
===================================================================
RCS file: /home/cvs/mdocml/mdocml/mdoc_macro.c,v
retrieving revision 1.160
retrieving revision 1.161
diff -Lmdoc_macro.c -Lmdoc_macro.c -u -p -r1.160 -r1.161
--- mdoc_macro.c
+++ mdoc_macro.c
@@ -363,7 +363,7 @@ rew_dohalt(enum mdoct tok, enum mdoc_typ
 	 * When starting to rewind, skip plain text
 	 * and nodes that have already been rewound.
 	 */
-	if (MDOC_TEXT == p->type || MDOC_VALID & p->flags)
+	if (p->type == MDOC_TEXT || p->flags & (MDOC_VALID | MDOC_BREAK))
 		return(REWIND_MORE);
 
 	/*
@@ -746,7 +746,7 @@ blk_exp_close(MACRO_PROT_ARGS)
 	atok = rew_alt(tok);
 	body = endbody = later = NULL;
 	for (n = mdoc->last; n; n = n->parent) {
-		if (n->flags & MDOC_VALID)
+		if (n->flags & (MDOC_VALID | MDOC_BREAK))
 			continue;
 
 		/* Remember the start of our own body. */
--
 To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-12-22 23:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-22 23:28 mdocml: The code already pays attention not to close the same block schwarze

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).