source@mandoc.bsd.lv
 help / color / mirror / Atom feed
* mdocml: Patch from Christian Neukirchen <chneukirchen at gmail dot com>:
@ 2015-03-20 15:25 schwarze
  0 siblings, 0 replies; only message in thread
From: schwarze @ 2015-03-20 15:25 UTC (permalink / raw)
  To: source

Log Message:
-----------
Patch from Christian Neukirchen <chneukirchen at gmail dot com>:
He reports that on some platforms, it is not possible to use the
same va_list twice.  So use va_copy(3) for additional safety.

Modified Files:
--------------
    mdocml:
        compat_vasprintf.c

Revision Data
-------------
Index: compat_vasprintf.c
===================================================================
RCS file: /home/cvs/mdocml/mdocml/compat_vasprintf.c,v
retrieving revision 1.1
retrieving revision 1.2
diff -Lcompat_vasprintf.c -Lcompat_vasprintf.c -u -p -r1.1 -r1.2
--- compat_vasprintf.c
+++ compat_vasprintf.c
@@ -37,10 +37,14 @@ int
 vasprintf(char **ret, const char *format, va_list ap)
 {
 	char	 buf[2];
+	va_list	 ap2;
 	int	 sz;
 
-	if ((sz = vsnprintf(buf, sizeof(buf), format, ap)) != -1 &&
-	    (*ret = malloc(sz + 1)) != NULL) {
+	va_copy(ap2, ap);
+	sz = vsnprintf(buf, sizeof(buf), format, ap2);
+	va_end(ap2);
+
+	if (sz != -1 && (*ret = malloc(sz + 1)) != NULL) {
 		if (vsnprintf(*ret, sz + 1, format, ap) == sz)
 			return(sz);
 		free(*ret);
--
 To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-03-20 15:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-20 15:25 mdocml: Patch from Christian Neukirchen <chneukirchen at gmail dot com>: schwarze

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).