source@mandoc.bsd.lv
 help / color / mirror / Atom feed
* mdocml: Don't printf("%s", NULL) if .It has a macro as an argument  in a
@ 2016-08-10 12:30 schwarze
  0 siblings, 0 replies; only message in thread
From: schwarze @ 2016-08-10 12:30 UTC (permalink / raw)
  To: source

Log Message:
-----------
Don't printf("%s", NULL) if .It has a macro as an argument 
in a list of a type where items don't takes arguments.
Issue found by tb@ with afl(1).

Modified Files:
--------------
    mdocml:
        mdoc_validate.c

Revision Data
-------------
Index: mdoc_validate.c
===================================================================
RCS file: /home/cvs/mdocml/mdocml/mdoc_validate.c,v
retrieving revision 1.303
retrieving revision 1.304
diff -Lmdoc_validate.c -Lmdoc_validate.c -u -p -r1.303 -r1.304
--- mdoc_validate.c
+++ mdoc_validate.c
@@ -1064,10 +1064,11 @@ post_it(POST_ARGS)
 			    mdoc_argnames[nbl->args->argv[0].arg]);
 		/* FALLTHROUGH */
 	case LIST_item:
-		if (nit->head->child != NULL)
+		if ((nch = nit->head->child) != NULL)
 			mandoc_vmsg(MANDOCERR_ARG_SKIP,
 			    mdoc->parse, nit->line, nit->pos,
-			    "It %s", nit->head->child->string);
+			    "It %s", nch->string == NULL ?
+			    mdoc_macronames[nch->tok] : nch->string);
 		break;
 	case LIST_column:
 		cols = (int)nbl->norm->Bl.ncols;
--
 To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-10 12:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-10 12:30 mdocml: Don't printf("%s", NULL) if .It has a macro as an argument in a schwarze

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).