From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: source@mdocml.bsd.lv
Subject: Re: mdocml: Rudimentary implementation of user-defined strings; no time for
Date: Thu, 15 Jul 2010 18:53:09 +0200 [thread overview]
Message-ID: <20100715165309.GA2359@britannica.bec.de> (raw)
In-Reply-To: <20100703162106.GC4327@iris.usta.de>
On Sat, Jul 03, 2010 at 06:21:06PM +0200, Ingo Schwarze wrote:
> > Ingo, did you mean this?
>
> > Index: roff.c
> > ===================================================================
> > RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/roff.c,v
> > retrieving revision 1.92
> > diff -u -r1.92 roff.c
> > --- roff.c 3 Jul 2010 16:02:12 -0000 1.92
> > +++ roff.c 3 Jul 2010 16:14:39 -0000
> > @@ -899,7 +899,7 @@
> > while (*string && ' ' != *string)
> > string++;
> > if (*string)
> > - *(string++) = NULL;
> > + *(string++) = '\0';
> > if (*string && '"' == *string)
> > string++;
> > while (*string && ' ' == *string)
>
> NO!
>
> I have put NULL on purpose.
> NULL, here, is supposed to mean:
>
> This string is not currently defined.
Well, *(string++) is still a char. It is not a pointer and as such it
triggers a GCC warning.
Joerg
--
To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv
next prev parent reply other threads:[~2010-07-15 16:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-03 16:02 schwarze
2010-07-03 16:12 ` Kristaps Dzonsons
2010-07-03 16:21 ` Ingo Schwarze
2010-07-03 16:27 ` Kristaps Dzonsons
2010-07-15 16:53 ` Joerg Sonnenberger [this message]
2010-07-25 18:58 ` Joerg Sonnenberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100715165309.GA2359@britannica.bec.de \
--to=joerg@britannica.bec.de \
--cc=source@mdocml.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).