From: schwarze@mdocml.bsd.lv
To: source@mdocml.bsd.lv
Subject: mdocml: Backout previous.
Date: Sat, 21 Aug 2010 10:04:13 -0400 (EDT) [thread overview]
Message-ID: <201008211404.o7LE4D9r014169@krisdoz.my.domain> (raw)
Log Message:
-----------
Backout previous.
As Kristaps found out, i was wrong: .Bl -column phrases do not ignore
spacing rules for trailing punctuation in general. In particular,
- the rightmost column of a column list is unaffected
- columns terminated by the .Ta macro instead of a tab are unaffected
- columns ending in a blank are unaffected
Spacing rules for trailing punctuation are only ignored when the tab
follows the punctuation immediately, without a blank in between,
because then the combination of punctuation and tab is treated by roff
as a word, and the punctuation is not recognized as isolated.
The reason this doesn't work in mandoc is that in the special case
of .Bl -column (not in general!), mandoc treats tabs as word delimiters.
We either need to solve this differently, or call it a bug in roff.
Modified Files:
--------------
mdocml:
mdoc_term.c
Revision Data
-------------
Index: mdoc_term.c
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/mdoc_term.c,v
retrieving revision 1.182
retrieving revision 1.183
diff -Lmdoc_term.c -Lmdoc_term.c -u -p -r1.182 -r1.183
--- mdoc_term.c
+++ mdoc_term.c
@@ -842,8 +842,6 @@ termp_it_pre(DECL_ARGS)
if (MDOC_BODY == n->prev->type)
p->flags |= TERMP_NOLPAD;
- p->flags |= TERMP_IGNDELIM;
-
break;
case (LIST_diag):
if (MDOC_HEAD == n->type)
@@ -1002,13 +1000,6 @@ termp_it_post(DECL_ARGS)
p->flags &= ~TERMP_TWOSPACE;
p->flags &= ~TERMP_NOLPAD;
p->flags &= ~TERMP_HANG;
-
- /*
- * TERMP_IGNDELIM is also set by `Pf', but it is safe
- * to clear it here because `Pf' cannot contain `It'.
- */
-
- p->flags &= ~TERMP_IGNDELIM;
}
@@ -1813,10 +1804,6 @@ static void
termp_pf_post(DECL_ARGS)
{
- /*
- * XXX Resetting TERMP_IGNDELIM here is not safe
- * because `Pf' can be used inside `Bl -column'.
- */
p->flags &= ~TERMP_IGNDELIM;
p->flags |= TERMP_NOSPACE;
}
--
To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv
reply other threads:[~2010-08-21 14:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008211404.o7LE4D9r014169@krisdoz.my.domain \
--to=schwarze@mdocml.bsd.lv \
--cc=source@mdocml.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).