source@mandoc.bsd.lv
 help / color / mirror / Atom feed
* mdocml: Backout previous.
@ 2010-08-21 14:04 schwarze
  0 siblings, 0 replies; only message in thread
From: schwarze @ 2010-08-21 14:04 UTC (permalink / raw)
  To: source

Log Message:
-----------
Backout previous.
As Kristaps found out, i was wrong: .Bl -column phrases do not ignore
spacing rules for trailing punctuation in general.  In particular,
- the rightmost column of a column list is unaffected
- columns terminated by the .Ta macro instead of a tab are unaffected
- columns ending in a blank are unaffected
Spacing rules for trailing punctuation are only ignored when the tab
follows the punctuation immediately, without a blank in between,
because then the combination of punctuation and tab is treated by roff
as a word, and the punctuation is not recognized as isolated.
The reason this doesn't work in mandoc is that in the special case
of .Bl -column (not in general!), mandoc treats tabs as word delimiters.
We either need to solve this differently, or call it a bug in roff.

Modified Files:
--------------
    mdocml:
        mdoc_term.c

Revision Data
-------------
Index: mdoc_term.c
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/mdoc_term.c,v
retrieving revision 1.182
retrieving revision 1.183
diff -Lmdoc_term.c -Lmdoc_term.c -u -p -r1.182 -r1.183
--- mdoc_term.c
+++ mdoc_term.c
@@ -842,8 +842,6 @@ termp_it_pre(DECL_ARGS)
 		if (MDOC_BODY == n->prev->type) 
 			p->flags |= TERMP_NOLPAD;
 
-		p->flags |= TERMP_IGNDELIM;
-
 		break;
 	case (LIST_diag):
 		if (MDOC_HEAD == n->type)
@@ -1002,13 +1000,6 @@ termp_it_post(DECL_ARGS)
 	p->flags &= ~TERMP_TWOSPACE;
 	p->flags &= ~TERMP_NOLPAD;
 	p->flags &= ~TERMP_HANG;
-
-	/*
-	 * TERMP_IGNDELIM is also set by `Pf', but it is safe
-	 * to clear it here because `Pf' cannot contain `It'.
-	 */
-
-	p->flags &= ~TERMP_IGNDELIM;
 }
 
 
@@ -1813,10 +1804,6 @@ static void
 termp_pf_post(DECL_ARGS)
 {
 
-	/*
-	 * XXX Resetting TERMP_IGNDELIM here is not safe
-	 * because `Pf' can be used inside `Bl -column'.
-	 */
 	p->flags &= ~TERMP_IGNDELIM;
 	p->flags |= TERMP_NOSPACE;
 }
--
 To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-08-21 14:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-21 14:04 mdocml: Backout previous schwarze

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).