From: schwarze@mdocml.bsd.lv
To: source@mdocml.bsd.lv
Subject: mdocml: Track the parser status both per file (file_status), such that
Date: Thu, 2 Dec 2010 15:41:46 -0500 (EST) [thread overview]
Message-ID: <201012022041.oB2Kfkg3002427@krisdoz.my.domain> (raw)
Log Message:
-----------
Track the parser status both per file (file_status), such that
we can for example skip rendering on FATAL parsing errors,
and globally (exit_status), such that we know what to return.
Without this, following files produced no rendered output
once a single file suffered from a FATAL error.
Bug reported by kristaps@, fix by me.
Modified Files:
--------------
mdocml:
main.c
Revision Data
-------------
Index: main.c
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/main.c,v
retrieving revision 1.114
retrieving revision 1.115
diff -Lmain.c -Lmain.c -u -p -r1.114 -r1.115
--- main.c
+++ main.c
@@ -213,6 +213,7 @@ static void version(void) __attribute
static int woptions(struct curparse *, char *);
static const char *progname;
+static enum mandoclevel file_status = MANDOCLEVEL_OK;
static enum mandoclevel exit_status = MANDOCLEVEL_OK;
int
@@ -349,7 +350,7 @@ pfile(const char *file, struct curparse
if (-1 == (fd = open(file, O_RDONLY, 0))) {
perror(file);
- exit_status = MANDOCLEVEL_SYSERR;
+ file_status = MANDOCLEVEL_SYSERR;
return(0);
}
@@ -367,7 +368,7 @@ pfile(const char *file, struct curparse
if (-1 == close(fd))
perror(file);
- return(MANDOCLEVEL_FATAL > exit_status ? 1 : 0);
+ return(MANDOCLEVEL_FATAL > file_status ? 1 : 0);
}
@@ -471,6 +472,7 @@ fdesc(struct curparse *curp)
curp->mdoc = NULL;
curp->man = NULL;
+ file_status = MANDOCLEVEL_OK;
/* Make sure the mandotory roff parser is initialised. */
@@ -483,32 +485,32 @@ fdesc(struct curparse *curp)
pdesc(curp);
- if (MANDOCLEVEL_FATAL <= exit_status)
+ if (MANDOCLEVEL_FATAL <= file_status)
goto cleanup;
/* NOTE a parser may not have been assigned, yet. */
if ( ! (curp->man || curp->mdoc)) {
fprintf(stderr, "%s: Not a manual\n", curp->file);
- exit_status = MANDOCLEVEL_FATAL;
+ file_status = MANDOCLEVEL_FATAL;
goto cleanup;
}
/* Clean up the parse routine ASTs. */
if (curp->mdoc && ! mdoc_endparse(curp->mdoc)) {
- assert(MANDOCLEVEL_FATAL <= exit_status);
+ assert(MANDOCLEVEL_FATAL <= file_status);
goto cleanup;
}
if (curp->man && ! man_endparse(curp->man)) {
- assert(MANDOCLEVEL_FATAL <= exit_status);
+ assert(MANDOCLEVEL_FATAL <= file_status);
goto cleanup;
}
assert(curp->roff);
if ( ! roff_endparse(curp->roff)) {
- assert(MANDOCLEVEL_FATAL <= exit_status);
+ assert(MANDOCLEVEL_FATAL <= file_status);
goto cleanup;
}
@@ -517,7 +519,7 @@ fdesc(struct curparse *curp)
* the requested level, do not produce output.
*/
- if (MANDOCLEVEL_OK != exit_status && curp->wstop)
+ if (MANDOCLEVEL_OK != file_status && curp->wstop)
goto cleanup;
/* If unset, allocate output dev now (if applicable). */
@@ -592,6 +594,9 @@ fdesc(struct curparse *curp)
assert(curp->roff);
roff_reset(curp->roff);
+ if (exit_status < file_status)
+ exit_status = file_status;
+
return;
}
@@ -609,7 +614,7 @@ pdesc(struct curparse *curp)
*/
if ( ! read_whole_file(curp, &blk, &with_mmap)) {
- exit_status = MANDOCLEVEL_SYSERR;
+ file_status = MANDOCLEVEL_SYSERR;
return;
}
@@ -762,7 +767,7 @@ rerun:
pos = 0;
continue;
case (ROFF_ERR):
- assert(MANDOCLEVEL_FATAL <= exit_status);
+ assert(MANDOCLEVEL_FATAL <= file_status);
break;
case (ROFF_SO):
if (pfile(ln.buf + of, curp)) {
@@ -798,7 +803,7 @@ rerun:
curp->line, ln.buf, of);
if ( ! rc) {
- assert(MANDOCLEVEL_FATAL <= exit_status);
+ assert(MANDOCLEVEL_FATAL <= file_status);
break;
}
}
@@ -980,8 +985,8 @@ mmsg(enum mandocerr t, void *arg, int ln
fprintf(stderr, ": %s", msg);
fputc('\n', stderr);
- if (exit_status < level)
- exit_status = level;
+ if (file_status < level)
+ file_status = level;
return(level < MANDOCLEVEL_FATAL);
}
--
To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv
reply other threads:[~2010-12-02 20:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012022041.oB2Kfkg3002427@krisdoz.my.domain \
--to=schwarze@mdocml.bsd.lv \
--cc=source@mdocml.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).