From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from krisdoz.my.domain (kristaps@localhost [127.0.0.1]) by krisdoz.my.domain (8.14.3/8.14.3) with ESMTP id p2NFXvWu030872 for ; Wed, 23 Mar 2011 11:33:57 -0400 (EDT) Received: (from kristaps@localhost) by krisdoz.my.domain (8.14.3/8.14.3/Submit) id p2NFXvtL003812; Wed, 23 Mar 2011 11:33:57 -0400 (EDT) Date: Wed, 23 Mar 2011 11:33:57 -0400 (EDT) Message-Id: <201103231533.p2NFXvtL003812@krisdoz.my.domain> X-Mailinglist: mdocml-source Reply-To: source@mdocml.bsd.lv MIME-Version: 1.0 From: kristaps@mdocml.bsd.lv To: source@mdocml.bsd.lv Subject: mdocml: Merge man_args() into man_macro.c, the only place where it's X-Mailer: activitymail 1.26, http://search.cpan.org/dist/activitymail/ Content-Type: text/plain; charset=utf-8 Log Message: ----------- Merge man_args() into man_macro.c, the only place where it's called, and make its return value boolean (we don't care about QWORD). We can move it into mdoc_macro.c because it's basically just a wrapper around mandoc_getarg(). Then blow away man_argv.c, which is left empty. Modified Files: -------------- mdocml: Makefile libman.h man_macro.c Removed Files: ------------- mdocml: man_argv.c Revision Data ------------- --- man_argv.c +++ /dev/null @@ -1,42 +0,0 @@ -/* $Id: man_argv.c,v 1.8 2011/03/23 12:40:04 kristaps Exp $ */ -/* - * Copyright (c) 2011 Ingo Schwarze - * - * Permission to use, copy, modify, and distribute this software for any - * purpose with or without fee is hereby granted, provided that the above - * copyright notice and this permission notice appear in all copies. - * - * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES - * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF - * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR - * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES - * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN - * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF - * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. - */ -#ifdef HAVE_CONFIG_H -#include "config.h" -#endif - -#include - -#include "man.h" -#include "mandoc.h" -#include "libman.h" -#include "libmandoc.h" - -enum margserr -man_args(struct man *m, int line, int *pos, char *buf, char **v) -{ - char *start; - - assert(*pos); - *v = start = buf + *pos; - assert(' ' != *start); - - if ('\0' == *start) - return(ARGS_EOLN); - - *v = mandoc_getarg(m->parse, v, line, pos); - return('"' == *start ? ARGS_QWORD : ARGS_WORD); -} Index: libman.h =================================================================== RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/libman.h,v retrieving revision 1.50 retrieving revision 1.51 diff -Llibman.h -Llibman.h -u -p -r1.50 -r1.51 --- libman.h +++ libman.h @@ -56,12 +56,6 @@ struct man_macro { #define MAN_NOCLOSE (1 << 4) /* See blk_exp(). */ }; -enum margserr { - ARGS_EOLN, - ARGS_WORD, - ARGS_QWORD -}; - extern const struct man_macro *const man_macros; __BEGIN_DECLS @@ -80,7 +74,6 @@ void man_node_delete(struct man *, st void man_hash_init(void); enum mant man_hash_find(const char *); int man_macroend(struct man *); -enum margserr man_args(struct man *, int, int *, char *, char **); int man_valid_post(struct man *); int man_valid_pre(struct man *, struct man_node *); int man_unscope(struct man *, Index: Makefile =================================================================== RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/Makefile,v retrieving revision 1.322 retrieving revision 1.323 diff -LMakefile -LMakefile -u -p -r1.322 -r1.323 --- Makefile +++ Makefile @@ -57,7 +57,6 @@ SRCS = Makefile \ main.h \ man.7 \ man.c \ - man_argv.c \ man_hash.c \ man_html.c \ man_macro.c \ @@ -104,7 +103,6 @@ SRCS = Makefile \ vol.in LIBMAN_OBJS = man.o \ - man_argv.o \ man_hash.o \ man_macro.o \ man_validate.o Index: man_macro.c =================================================================== RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/man_macro.c,v retrieving revision 1.59 retrieving revision 1.60 diff -Lman_macro.c -Lman_macro.c -u -p -r1.59 -r1.60 --- man_macro.c +++ man_macro.c @@ -38,6 +38,8 @@ static int blk_close(MACRO_PROT_ARGS); static int blk_exp(MACRO_PROT_ARGS); static int blk_imp(MACRO_PROT_ARGS); static int in_line_eoln(MACRO_PROT_ARGS); +static int man_args(struct man *, int, + int *, char *, char **); static int rew_scope(enum man_type, struct man *, enum mant); @@ -317,7 +319,7 @@ blk_exp(MACRO_PROT_ARGS) for (;;) { la = *pos; - if (ARGS_EOLN == man_args(m, line, pos, buf, &p)) + if ( ! man_args(m, line, pos, buf, &p)) break; if ( ! man_word_alloc(m, line, la, p)) return(0); @@ -367,7 +369,7 @@ blk_imp(MACRO_PROT_ARGS) for (;;) { la = *pos; - if (ARGS_EOLN == man_args(m, line, pos, buf, &p)) + if ( ! man_args(m, line, pos, buf, &p)) break; if ( ! man_word_alloc(m, line, la, p)) return(0); @@ -407,7 +409,7 @@ in_line_eoln(MACRO_PROT_ARGS) for (;;) { la = *pos; - if (ARGS_EOLN == man_args(m, line, pos, buf, &p)) + if ( ! man_args(m, line, pos, buf, &p)) break; if ( ! man_word_alloc(m, line, la, p)) return(0); @@ -470,3 +472,18 @@ man_macroend(struct man *m) return(man_unscope(m, m->first, MANDOCERR_SCOPEEXIT)); } +static int +man_args(struct man *m, int line, int *pos, char *buf, char **v) +{ + char *start; + + assert(*pos); + *v = start = buf + *pos; + assert(' ' != *start); + + if ('\0' == *start) + return(0); + + *v = mandoc_getarg(m->parse, v, line, pos); + return(1); +} -- To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv