From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from krisdoz.my.domain (kristaps@localhost [127.0.0.1]) by krisdoz.my.domain (8.14.3/8.14.3) with ESMTP id p4QLD7kp012313 for ; Thu, 26 May 2011 17:13:08 -0400 (EDT) Received: (from kristaps@localhost) by krisdoz.my.domain (8.14.3/8.14.3/Submit) id p4QLD7mO021833; Thu, 26 May 2011 17:13:07 -0400 (EDT) Date: Thu, 26 May 2011 17:13:07 -0400 (EDT) Message-Id: <201105262113.p4QLD7mO021833@krisdoz.my.domain> X-Mailinglist: mdocml-source Reply-To: source@mdocml.bsd.lv MIME-Version: 1.0 From: kristaps@mdocml.bsd.lv To: source@mdocml.bsd.lv Subject: mdocml: Some small lint checks in preconv. X-Mailer: activitymail 1.26, http://search.cpan.org/dist/activitymail/ Content-Type: text/plain; charset=utf-8 Log Message: ----------- Some small lint checks in preconv. Also add it to the default lint rule. Modified Files: -------------- mdocml: Makefile preconv.c Revision Data ------------- Index: Makefile =================================================================== RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/Makefile,v retrieving revision 1.347 retrieving revision 1.348 diff -LMakefile -LMakefile -u -p -r1.347 -r1.348 --- Makefile +++ Makefile @@ -298,7 +298,7 @@ INDEX_OBJS = $(INDEX_MANS) \ www: index.html -lint: llib-llibmandoc.ln llib-lmandoc.ln +lint: llib-llibmandoc.ln llib-lmandoc.ln llib-lpreconv.ln clean: rm -f libmandoc.a $(LIBMANDOC_OBJS) Index: preconv.c =================================================================== RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/preconv.c,v retrieving revision 1.3 retrieving revision 1.4 diff -Lpreconv.c -Lpreconv.c -u -p -r1.3 -r1.4 --- preconv.c +++ preconv.c @@ -137,7 +137,7 @@ conv_utf_8(const struct buf *b) /* Quick test for big-endian value. */ - if ( ! (*((char *)(&one)))) + if ( ! (*((const char *)(&one)))) be = 1; for (i = b->offs; i < b->sz; i++) { @@ -376,7 +376,7 @@ cue_enc(const struct buf *b, size_t *off /* Check us against known encodings. */ - for (i = 0; i < ENC__MAX; i++) { + for (i = 0; i < (int)ENC__MAX; i++) { nsz = strlen(encs[i].name); if (phsz < nsz) continue; @@ -403,7 +403,7 @@ main(int argc, char *argv[]) struct buf b; const char *fn; enum enc enc, def; - const char bom[3] = { 0xEF, 0xBB, 0xBF }; + unsigned char bom[3] = { 0xEF, 0xBB, 0xBF }; size_t offs; extern int optind; extern char *optarg; @@ -427,12 +427,12 @@ main(int argc, char *argv[]) case ('D'): /* FALLTHROUGH */ case ('e'): - for (i = 0; i < ENC__MAX; i++) { + for (i = 0; i < (int)ENC__MAX; i++) { if (strcasecmp(optarg, encs[i].name)) continue; break; } - if (i < ENC__MAX) { + if (i < (int)ENC__MAX) { if ('D' == ch) def = (enum enc)i; else -- To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv