* mdocml: The name "struct tbl" was badly misleading for two reasons: 1)
@ 2013-05-31 21:37 schwarze
0 siblings, 0 replies; only message in thread
From: schwarze @ 2013-05-31 21:37 UTC (permalink / raw)
To: source
Log Message:
-----------
The name "struct tbl" was badly misleading for two reasons:
1) This struct almost exclusively contains the table options.
2) Information about the table as a whole is actually in "struct tbl_node".
Besides, "struct tbl" was almost impossible to search for.
So rename it to "struct tbl_opts". No functional change.
Modified Files:
--------------
mdocml:
libroff.h
mandoc.h
out.c
tbl_data.c
tbl_term.c
Revision Data
-------------
Index: tbl_data.c
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/tbl_data.c,v
retrieving revision 1.25
retrieving revision 1.26
diff -Ltbl_data.c -Ltbl_data.c -u -p -r1.25 -r1.26
--- tbl_data.c
+++ tbl_data.c
@@ -185,7 +185,7 @@ newspan(struct tbl_node *tbl, int line,
dp = mandoc_calloc(1, sizeof(struct tbl_span));
dp->line = line;
- dp->tbl = &tbl->opts;
+ dp->opts = &tbl->opts;
dp->layout = rp;
dp->head = tbl->first_head;
Index: out.c
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/out.c,v
retrieving revision 1.44
retrieving revision 1.45
diff -Lout.c -Lout.c -u -p -r1.44 -r1.45
--- out.c
+++ out.c
@@ -32,11 +32,11 @@
#include "out.h"
static void tblcalc_data(struct rofftbl *, struct roffcol *,
- const struct tbl *, const struct tbl_dat *);
+ const struct tbl_opts *, const struct tbl_dat *);
static void tblcalc_literal(struct rofftbl *, struct roffcol *,
const struct tbl_dat *);
static void tblcalc_number(struct rofftbl *, struct roffcol *,
- const struct tbl *, const struct tbl_dat *);
+ const struct tbl_opts *, const struct tbl_dat *);
/*
* Convert a `scaling unit' to a consistent form, or fail. Scaling
@@ -154,7 +154,7 @@ tblcalc(struct rofftbl *tbl, const struc
assert(NULL == tbl->cols);
tbl->cols = mandoc_calloc
- ((size_t)sp->tbl->cols, sizeof(struct roffcol));
+ ((size_t)sp->opts->cols, sizeof(struct roffcol));
hp = sp->head;
@@ -175,14 +175,14 @@ tblcalc(struct rofftbl *tbl, const struc
continue;
assert(dp->layout);
col = &tbl->cols[dp->layout->head->ident];
- tblcalc_data(tbl, col, sp->tbl, dp);
+ tblcalc_data(tbl, col, sp->opts, dp);
}
}
}
static void
tblcalc_data(struct rofftbl *tbl, struct roffcol *col,
- const struct tbl *tp, const struct tbl_dat *dp)
+ const struct tbl_opts *opts, const struct tbl_dat *dp)
{
size_t sz;
@@ -206,7 +206,7 @@ tblcalc_data(struct rofftbl *tbl, struct
tblcalc_literal(tbl, col, dp);
break;
case (TBL_CELL_NUMBER):
- tblcalc_number(tbl, col, tp, dp);
+ tblcalc_number(tbl, col, opts, dp);
break;
case (TBL_CELL_DOWN):
break;
@@ -232,7 +232,7 @@ tblcalc_literal(struct rofftbl *tbl, str
static void
tblcalc_number(struct rofftbl *tbl, struct roffcol *col,
- const struct tbl *tp, const struct tbl_dat *dp)
+ const struct tbl_opts *opts, const struct tbl_dat *dp)
{
int i;
size_t sz, psz, ssz, d;
@@ -254,12 +254,12 @@ tblcalc_number(struct rofftbl *tbl, stru
/* FIXME: TBL_DATA_HORIZ et al.? */
- buf[0] = tp->decimal;
+ buf[0] = opts->decimal;
buf[1] = '\0';
psz = (*tbl->slen)(buf, tbl->arg);
- if (NULL != (cp = strrchr(str, tp->decimal))) {
+ if (NULL != (cp = strrchr(str, opts->decimal))) {
buf[1] = '\0';
for (ssz = 0, i = 0; cp != &str[i]; i++) {
buf[0] = str[i];
Index: tbl_term.c
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/tbl_term.c,v
retrieving revision 1.24
retrieving revision 1.25
diff -Ltbl_term.c -Ltbl_term.c -u -p -r1.24 -r1.25
--- tbl_term.c
+++ tbl_term.c
@@ -31,14 +31,14 @@
static size_t term_tbl_len(size_t, void *);
static size_t term_tbl_strlen(const char *, void *);
static void tbl_char(struct termp *, char, size_t);
-static void tbl_data(struct termp *, const struct tbl *,
+static void tbl_data(struct termp *, const struct tbl_opts *,
const struct tbl_dat *,
const struct roffcol *);
static size_t tbl_rulewidth(struct termp *, const struct tbl_head *);
static void tbl_hframe(struct termp *, const struct tbl_span *, int);
static void tbl_literal(struct termp *, const struct tbl_dat *,
const struct roffcol *);
-static void tbl_number(struct termp *, const struct tbl *,
+static void tbl_number(struct termp *, const struct tbl_opts *,
const struct tbl_dat *,
const struct roffcol *);
static void tbl_hrule(struct termp *, const struct tbl_span *);
@@ -96,16 +96,16 @@ term_tbl(struct termp *tp, const struct
/* Horizontal frame at the start of boxed tables. */
if (TBL_SPAN_FIRST & sp->flags) {
- if (TBL_OPT_DBOX & sp->tbl->opts)
+ if (TBL_OPT_DBOX & sp->opts->opts)
tbl_hframe(tp, sp, 1);
- if (TBL_OPT_DBOX & sp->tbl->opts ||
- TBL_OPT_BOX & sp->tbl->opts)
+ if (TBL_OPT_DBOX & sp->opts->opts ||
+ TBL_OPT_BOX & sp->opts->opts)
tbl_hframe(tp, sp, 0);
}
/* Vertical frame at the start of each row. */
- if (TBL_OPT_BOX & sp->tbl->opts || TBL_OPT_DBOX & sp->tbl->opts)
+ if (TBL_OPT_BOX & sp->opts->opts || TBL_OPT_DBOX & sp->opts->opts)
term_word(tp, TBL_SPAN_HORIZ == sp->pos ||
TBL_SPAN_DHORIZ == sp->pos ? "+" : "|");
@@ -142,7 +142,7 @@ term_tbl(struct termp *tp, const struct
tbl_vrule(tp, hp);
col = &tp->tbl.cols[hp->ident];
- tbl_data(tp, sp->tbl, dp, col);
+ tbl_data(tp, sp->opts, dp, col);
/*
* Go to the next data cell and assign the
@@ -159,7 +159,7 @@ term_tbl(struct termp *tp, const struct
/* Vertical frame at the end of each row. */
- if (TBL_OPT_BOX & sp->tbl->opts || TBL_OPT_DBOX & sp->tbl->opts)
+ if (TBL_OPT_BOX & sp->opts->opts || TBL_OPT_DBOX & sp->opts->opts)
term_word(tp, TBL_SPAN_HORIZ == sp->pos ||
TBL_SPAN_DHORIZ == sp->pos ? "+" : " |");
term_flushln(tp);
@@ -170,12 +170,12 @@ term_tbl(struct termp *tp, const struct
*/
if (TBL_SPAN_LAST & sp->flags) {
- if (TBL_OPT_DBOX & sp->tbl->opts ||
- TBL_OPT_BOX & sp->tbl->opts) {
+ if (TBL_OPT_DBOX & sp->opts->opts ||
+ TBL_OPT_BOX & sp->opts->opts) {
tbl_hframe(tp, sp, 0);
tp->skipvsp = 1;
}
- if (TBL_OPT_DBOX & sp->tbl->opts) {
+ if (TBL_OPT_DBOX & sp->opts->opts) {
tbl_hframe(tp, sp, 1);
tp->skipvsp = 2;
}
@@ -254,7 +254,7 @@ tbl_hframe(struct termp *tp, const struc
}
static void
-tbl_data(struct termp *tp, const struct tbl *tbl,
+tbl_data(struct termp *tp, const struct tbl_opts *opts,
const struct tbl_dat *dp,
const struct roffcol *col)
{
@@ -300,7 +300,7 @@ tbl_data(struct termp *tp, const struct
tbl_literal(tp, dp, col);
break;
case (TBL_CELL_NUMBER):
- tbl_number(tp, tbl, dp, col);
+ tbl_number(tp, opts, dp, col);
break;
case (TBL_CELL_DOWN):
tbl_char(tp, ASCII_NBRSP, col->width);
@@ -381,7 +381,7 @@ tbl_literal(struct termp *tp, const stru
}
static void
-tbl_number(struct termp *tp, const struct tbl *tbl,
+tbl_number(struct termp *tp, const struct tbl_opts *opts,
const struct tbl_dat *dp,
const struct roffcol *col)
{
@@ -399,12 +399,12 @@ tbl_number(struct termp *tp, const struc
sz = term_strlen(tp, dp->string);
- buf[0] = tbl->decimal;
+ buf[0] = opts->decimal;
buf[1] = '\0';
psz = term_strlen(tp, buf);
- if (NULL != (cp = strrchr(dp->string, tbl->decimal))) {
+ if (NULL != (cp = strrchr(dp->string, opts->decimal))) {
buf[1] = '\0';
for (ssz = 0, i = 0; cp != &dp->string[i]; i++) {
buf[0] = dp->string[i];
Index: mandoc.h
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/mandoc.h,v
retrieving revision 1.106
retrieving revision 1.107
diff -Lmandoc.h -Lmandoc.h -u -p -r1.106 -r1.107
--- mandoc.h
+++ mandoc.h
@@ -164,7 +164,7 @@ enum mandocerr {
MANDOCERR_MAX
};
-struct tbl {
+struct tbl_opts {
char tab; /* cell-separator */
char decimal; /* decimal point */
int linesize;
@@ -263,7 +263,7 @@ enum tbl_spant {
* A row of data in a table.
*/
struct tbl_span {
- struct tbl *tbl;
+ struct tbl_opts *opts;
struct tbl_head *head;
struct tbl_row *layout; /* layout row */
struct tbl_dat *first;
Index: libroff.h
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/libroff.h,v
retrieving revision 1.27
retrieving revision 1.28
diff -Llibroff.h -Llibroff.h -u -p -r1.27 -r1.28
--- libroff.h
+++ libroff.h
@@ -31,7 +31,7 @@ struct tbl_node {
int pos; /* invocation column */
int line; /* invocation line */
enum tbl_part part;
- struct tbl opts;
+ struct tbl_opts opts;
struct tbl_row *first_row;
struct tbl_row *last_row;
struct tbl_span *first_span;
--
To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-05-31 21:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-31 21:37 mdocml: The name "struct tbl" was badly misleading for two reasons: 1) schwarze
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).