From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from krisdoz.my.domain (schwarze@localhost [127.0.0.1]) by krisdoz.my.domain (8.14.5/8.14.5) with ESMTP id s3G0XlUB013504 for ; Tue, 15 Apr 2014 20:33:47 -0400 (EDT) Received: (from schwarze@localhost) by krisdoz.my.domain (8.14.5/8.14.3/Submit) id s3G0Xlv8020479; Tue, 15 Apr 2014 20:33:47 -0400 (EDT) Date: Tue, 15 Apr 2014 20:33:47 -0400 (EDT) Message-Id: <201404160033.s3G0Xlv8020479@krisdoz.my.domain> X-Mailinglist: mdocml-source Reply-To: source@mdocml.bsd.lv MIME-Version: 1.0 From: schwarze@mdocml.bsd.lv To: source@mdocml.bsd.lv Subject: mdocml: Pass the function flags SQLITE_UTF8 (because SQLITE_ANY is X-Mailer: activitymail 1.26, http://search.cpan.org/dist/activitymail/ Content-Type: text/plain; charset=utf-8 Log Message: ----------- Pass the function flags SQLITE_UTF8 (because SQLITE_ANY is deprecated) and SQLITE_DETERMINISTIC when creating deterministic functions; best practice measure suggested by espie@ and jeremy@; as expected by jeremy@, no measurable effect on performance. Modified Files: -------------- mdocml: mansearch.c Revision Data ------------- Index: mansearch.c =================================================================== RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/mansearch.c,v retrieving revision 1.30 retrieving revision 1.31 diff -Lmansearch.c -Lmansearch.c -u -p -r1.30 -r1.31 --- mansearch.c +++ mansearch.c @@ -253,10 +253,12 @@ mansearch(const struct mansearch *search */ c = sqlite3_create_function(db, "match", 2, - SQLITE_ANY, NULL, sql_match, NULL, NULL); + SQLITE_UTF8 | SQLITE_DETERMINISTIC, + NULL, sql_match, NULL, NULL); assert(SQLITE_OK == c); c = sqlite3_create_function(db, "regexp", 2, - SQLITE_ANY, NULL, sql_regexp, NULL, NULL); + SQLITE_UTF8 | SQLITE_DETERMINISTIC, + NULL, sql_regexp, NULL, NULL); assert(SQLITE_OK == c); j = 1; -- To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv