From: schwarze@mdocml.bsd.lv
To: source@mdocml.bsd.lv
Subject: mdocml: Rename the mpages.id column to mpages.pageid.
Date: Wed, 16 Apr 2014 17:36:18 -0400 (EDT) [thread overview]
Message-ID: <201404162136.s3GLaIJh005751@krisdoz.my.domain> (raw)
Log Message:
-----------
Rename the mpages.id column to mpages.pageid. There is no good reason
to call this kid by a different name here than in all other tables.
Modified Files:
--------------
mdocml:
mandocdb.c
mansearch.c
Revision Data
-------------
Index: mansearch.c
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/mansearch.c,v
retrieving revision 1.31
retrieving revision 1.32
diff -Lmansearch.c -Lmansearch.c -u -p -r1.31 -r1.32
--- mansearch.c
+++ mansearch.c
@@ -74,7 +74,7 @@ struct expr {
};
struct match {
- uint64_t id; /* identifier in database */
+ uint64_t pageid; /* identifier in database */
char *desc; /* manual page description */
int form; /* 0 == catpage */
};
@@ -156,7 +156,7 @@ mansearch(const struct mansearch *search
struct manpage **res, size_t *sz)
{
int fd, rc, c, indexbit;
- int64_t id;
+ int64_t pageid;
uint64_t outbit, iterbit;
char buf[PATH_MAX];
char *sql;
@@ -175,7 +175,7 @@ mansearch(const struct mansearch *search
info.halloc = hash_halloc;
info.alloc = hash_alloc;
info.hfree = hash_free;
- info.key_offset = offsetof(struct match, id);
+ info.key_offset = offsetof(struct match, pageid);
*sz = cur = maxres = 0;
sql = NULL;
@@ -287,16 +287,16 @@ mansearch(const struct mansearch *search
* distribution of buckets in the table.
*/
while (SQLITE_ROW == (c = sqlite3_step(s))) {
- id = sqlite3_column_int64(s, 2);
+ pageid = sqlite3_column_int64(s, 2);
idx = ohash_lookup_memory
- (&htab, (char *)&id,
- sizeof(uint64_t), (uint32_t)id);
+ (&htab, (char *)&pageid,
+ sizeof(uint64_t), (uint32_t)pageid);
if (NULL != ohash_find(&htab, idx))
continue;
mp = mandoc_calloc(1, sizeof(struct match));
- mp->id = id;
+ mp->pageid = pageid;
mp->form = sqlite3_column_int(s, 1);
if (TYPE_Nd == outbit)
mp->desc = mandoc_strdup(
@@ -332,11 +332,11 @@ mansearch(const struct mansearch *search
}
mpage = *res + cur;
mpage->form = mp->form;
- buildnames(mpage, db, s, mp->id,
+ buildnames(mpage, db, s, mp->pageid,
paths->paths[i], mp->form);
mpage->output = TYPE_Nd & outbit ?
mp->desc : outbit ?
- buildoutput(db, s2, mp->id, outbit) : NULL;
+ buildoutput(db, s2, mp->pageid, outbit) : NULL;
free(mp);
cur++;
@@ -362,7 +362,7 @@ out:
static void
buildnames(struct manpage *mpage, sqlite3 *db, sqlite3_stmt *s,
- uint64_t id, const char *path, int form)
+ uint64_t pageid, const char *path, int form)
{
char *newnames, *prevsec, *prevarch;
const char *oldnames, *sep1, *name, *sec, *sep2, *arch, *fsec;
@@ -373,7 +373,7 @@ buildnames(struct manpage *mpage, sqlite
mpage->names = NULL;
prevsec = prevarch = NULL;
i = 1;
- SQL_BIND_INT64(db, s, i, id);
+ SQL_BIND_INT64(db, s, i, pageid);
while (SQLITE_ROW == (c = sqlite3_step(s))) {
/* Decide whether we already have some names. */
@@ -455,7 +455,7 @@ buildnames(struct manpage *mpage, sqlite
}
static char *
-buildoutput(sqlite3 *db, sqlite3_stmt *s, uint64_t id, uint64_t outbit)
+buildoutput(sqlite3 *db, sqlite3_stmt *s, uint64_t pageid, uint64_t outbit)
{
char *output, *newoutput;
const char *oldoutput, *sep1, *data;
@@ -464,7 +464,7 @@ buildoutput(sqlite3 *db, sqlite3_stmt *s
output = NULL;
i = 1;
- SQL_BIND_INT64(db, s, i, id);
+ SQL_BIND_INT64(db, s, i, pageid);
SQL_BIND_INT64(db, s, i, outbit);
while (SQLITE_ROW == (c = sqlite3_step(s))) {
if (NULL == output) {
@@ -559,14 +559,14 @@ sql_statement(const struct expr *e)
: "desc MATCH ?")
: TYPE_Nm == e->bits
? (NULL == e->substr
- ? "id IN (SELECT pageid FROM names "
+ ? "pageid IN (SELECT pageid FROM names "
"WHERE name REGEXP ?)"
- : "id IN (SELECT pageid FROM names "
+ : "pageid IN (SELECT pageid FROM names "
"WHERE name MATCH ?)")
: (NULL == e->substr
- ? "id IN (SELECT pageid FROM keys "
+ ? "pageid IN (SELECT pageid FROM keys "
"WHERE key REGEXP ? AND bits & ?)"
- : "id IN (SELECT pageid FROM keys "
+ : "pageid IN (SELECT pageid FROM keys "
"WHERE key MATCH ? AND bits & ?)"), 1);
if (e->close)
sql_append(&sql, &sz, ")", e->close);
Index: mandocdb.c
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/mandocdb.c,v
retrieving revision 1.136
retrieving revision 1.137
diff -Lmandocdb.c -Lmandocdb.c -u -p -r1.136 -r1.137
--- mandocdb.c
+++ mandocdb.c
@@ -100,7 +100,7 @@ struct inodev {
struct mpage {
struct inodev inodev; /* used for hashing routine */
- int64_t recno; /* id in mpages SQL table */
+ int64_t pageid; /* pageid in mpages SQL table */
enum form form; /* format from file content */
char *sec; /* section from file content */
char *arch; /* architecture from file content */
@@ -1099,7 +1099,7 @@ mpages_merge(struct mchars *mc, struct m
* to the target.
*/
- if (mpage_dest->recno)
+ if (mpage_dest->pageid)
dbadd_mlink(mlink);
if (NULL == mlink->next)
@@ -1892,7 +1892,7 @@ dbadd_mlink(const struct mlink *mlink)
SQL_BIND_TEXT(stmts[STMT_INSERT_LINK], i, mlink->dsec);
SQL_BIND_TEXT(stmts[STMT_INSERT_LINK], i, mlink->arch);
SQL_BIND_TEXT(stmts[STMT_INSERT_LINK], i, mlink->name);
- SQL_BIND_INT64(stmts[STMT_INSERT_LINK], i, mlink->mpage->recno);
+ SQL_BIND_INT64(stmts[STMT_INSERT_LINK], i, mlink->mpage->pageid);
SQL_STEP(stmts[STMT_INSERT_LINK]);
sqlite3_reset(stmts[STMT_INSERT_LINK]);
}
@@ -1944,7 +1944,7 @@ dbadd(struct mpage *mpage, struct mchars
SQL_BIND_TEXT(stmts[STMT_INSERT_PAGE], i, mpage->desc);
SQL_BIND_INT(stmts[STMT_INSERT_PAGE], i, FORM_SRC == mpage->form);
SQL_STEP(stmts[STMT_INSERT_PAGE]);
- mpage->recno = sqlite3_last_insert_rowid(db);
+ mpage->pageid = sqlite3_last_insert_rowid(db);
sqlite3_reset(stmts[STMT_INSERT_PAGE]);
while (NULL != mlink) {
@@ -1961,7 +1961,7 @@ dbadd(struct mpage *mpage, struct mchars
i = 1;
SQL_BIND_INT64(stmts[STMT_INSERT_NAME], i, key->mask);
SQL_BIND_TEXT(stmts[STMT_INSERT_NAME], i, key->rendered);
- SQL_BIND_INT64(stmts[STMT_INSERT_NAME], i, mpage->recno);
+ SQL_BIND_INT64(stmts[STMT_INSERT_NAME], i, mpage->pageid);
SQL_STEP(stmts[STMT_INSERT_NAME]);
sqlite3_reset(stmts[STMT_INSERT_NAME]);
if (key->rendered != key->key)
@@ -1976,7 +1976,7 @@ dbadd(struct mpage *mpage, struct mchars
i = 1;
SQL_BIND_INT64(stmts[STMT_INSERT_KEY], i, key->mask);
SQL_BIND_TEXT(stmts[STMT_INSERT_KEY], i, key->rendered);
- SQL_BIND_INT64(stmts[STMT_INSERT_KEY], i, mpage->recno);
+ SQL_BIND_INT64(stmts[STMT_INSERT_KEY], i, mpage->pageid);
SQL_STEP(stmts[STMT_INSERT_KEY]);
sqlite3_reset(stmts[STMT_INSERT_KEY]);
if (key->rendered != key->key)
@@ -2172,14 +2172,14 @@ create_tables:
sql = "CREATE TABLE \"mpages\" (\n"
" \"desc\" TEXT NOT NULL,\n"
" \"form\" INTEGER NOT NULL,\n"
- " \"id\" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL\n"
+ " \"pageid\" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL\n"
");\n"
"\n"
"CREATE TABLE \"mlinks\" (\n"
" \"sec\" TEXT NOT NULL,\n"
" \"arch\" TEXT NOT NULL,\n"
" \"name\" TEXT NOT NULL,\n"
- " \"pageid\" INTEGER NOT NULL REFERENCES mpages(id) "
+ " \"pageid\" INTEGER NOT NULL REFERENCES mpages(pageid) "
"ON DELETE CASCADE\n"
");\n"
"CREATE INDEX mlinks_pageid_idx ON mlinks (pageid);\n"
@@ -2187,14 +2187,14 @@ create_tables:
"CREATE TABLE \"names\" (\n"
" \"bits\" INTEGER NOT NULL,\n"
" \"name\" TEXT NOT NULL,\n"
- " \"pageid\" INTEGER NOT NULL REFERENCES mpages(id) "
+ " \"pageid\" INTEGER NOT NULL REFERENCES mpages(pageid) "
"ON DELETE CASCADE\n"
");\n"
"\n"
"CREATE TABLE \"keys\" (\n"
" \"bits\" INTEGER NOT NULL,\n"
" \"key\" TEXT NOT NULL,\n"
- " \"pageid\" INTEGER NOT NULL REFERENCES mpages(id) "
+ " \"pageid\" INTEGER NOT NULL REFERENCES mpages(pageid) "
"ON DELETE CASCADE\n"
");\n"
"CREATE INDEX keys_pageid_idx ON keys (pageid);\n";
@@ -2207,7 +2207,7 @@ create_tables:
prepare_statements:
SQL_EXEC("PRAGMA foreign_keys = ON");
- sql = "DELETE FROM mpages WHERE id IN "
+ sql = "DELETE FROM mpages WHERE pageid IN "
"(SELECT pageid FROM mlinks WHERE "
"sec=? AND arch=? AND name=?)";
sqlite3_prepare_v2(db, sql, -1, &stmts[STMT_DELETE_PAGE], NULL);
--
To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv
reply other threads:[~2014-04-16 21:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201404162136.s3GLaIJh005751@krisdoz.my.domain \
--to=schwarze@mdocml.bsd.lv \
--cc=source@mdocml.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).