From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from krisdoz.my.domain (schwarze@localhost [127.0.0.1])
	by krisdoz.my.domain (8.14.5/8.14.5) with ESMTP id s5TLKVnm030771
	for <source@mdocml.bsd.lv>; Sun, 29 Jun 2014 17:20:31 -0400 (EDT)
Received: (from schwarze@localhost)
	by krisdoz.my.domain (8.14.5/8.14.3/Submit) id s5TLKVB4001341;
	Sun, 29 Jun 2014 17:20:31 -0400 (EDT)
Date: Sun, 29 Jun 2014 17:20:31 -0400 (EDT)
Message-Id: <201406292120.s5TLKVB4001341@krisdoz.my.domain>
X-Mailinglist: mdocml-source
Reply-To: source@mdocml.bsd.lv
MIME-Version: 1.0
From: schwarze@mdocml.bsd.lv
To: source@mdocml.bsd.lv
Subject: mdocml: Bugfix in roff_setstrn(): Do not call strcmp() on an array of 
X-Mailer: activitymail 1.26, http://search.cpan.org/dist/activitymail/
Content-Type: text/plain; charset=utf-8

Log Message:
-----------
Bugfix in roff_setstrn():
Do not call strcmp() on an array of char that might not be NUL-terminated.

Modified Files:
--------------
    mdocml:
        roff.c

Revision Data
-------------
Index: roff.c
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/roff.c,v
retrieving revision 1.210
retrieving revision 1.211
diff -Lroff.c -Lroff.c -u -p -r1.210 -r1.211
--- roff.c
+++ roff.c
@@ -2068,7 +2068,8 @@ roff_setstrn(struct roffkv **r, const ch
 	/* Search for an existing string with the same name. */
 	n = *r;
 
-	while (n && strcmp(name, n->key.p))
+	while (n && (namesz != n->key.sz ||
+			strncmp(n->key.p, name, namesz)))
 		n = n->next;
 
 	if (NULL == n) {
--
 To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv