* mdocml: Bugfix in roff_setstrn(): Do not call strcmp() on an array of
@ 2014-06-29 21:20 schwarze
0 siblings, 0 replies; only message in thread
From: schwarze @ 2014-06-29 21:20 UTC (permalink / raw)
To: source
Log Message:
-----------
Bugfix in roff_setstrn():
Do not call strcmp() on an array of char that might not be NUL-terminated.
Modified Files:
--------------
mdocml:
roff.c
Revision Data
-------------
Index: roff.c
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/roff.c,v
retrieving revision 1.210
retrieving revision 1.211
diff -Lroff.c -Lroff.c -u -p -r1.210 -r1.211
--- roff.c
+++ roff.c
@@ -2068,7 +2068,8 @@ roff_setstrn(struct roffkv **r, const ch
/* Search for an existing string with the same name. */
n = *r;
- while (n && strcmp(name, n->key.p))
+ while (n && (namesz != n->key.sz ||
+ strncmp(n->key.p, name, namesz)))
n = n->next;
if (NULL == n) {
--
To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-06-29 21:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-29 21:20 mdocml: Bugfix in roff_setstrn(): Do not call strcmp() on an array of schwarze
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).