mdocml: mmap(2) requires MAP_PRIVATE ^ MAP_SHARED for flags; found by

mdocml: mmap(2) requires MAP_PRIVATE ^ MAP_SHARED for flags; found by

[schwarze]

Log Message:
-----------
mmap(2) requires MAP_PRIVATE ^ MAP_SHARED for flags;
found by kristaps@ on Mac OS X

Modified Files:
--------------
    mdocml:
        mansearch.c
        TODO

Revision Data
-------------
Index: mansearch.c
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/mansearch.c,v
retrieving revision 1.41
retrieving revision 1.42
diff -Lmansearch.c -Lmansearch.c -u -p -r1.41 -r1.42
--- mansearch.c
+++ mansearch.c
@@ -123,7 +123,8 @@ mansearch_setup(int start)
 		}
 
 		pagecache = mmap(NULL, PC_PAGESIZE * PC_NUMPAGES,
-		    PROT_READ | PROT_WRITE, MAP_ANON, -1, 0);
+		    PROT_READ | PROT_WRITE,
+		    MAP_SHARED | MAP_ANON, -1, 0);
 
 		if (MAP_FAILED == pagecache) {
 			perror("mmap");
Index: TODO
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/TODO,v
retrieving revision 1.175
retrieving revision 1.176
diff -LTODO -LTODO -u -p -r1.175 -r1.176
--- TODO
+++ TODO
@@ -399,6 +399,10 @@
 * performance issues
 ************************************************************************
 
+- Why are we using MAP_SHARED, not MAP_PRIVATE for mmap(2)?
+  How does SQLITE_CONFIG_PAGECACHE actually work?  Document it!
+  from kristaps@  Sat, 09 Aug 2014 13:51:36 +0200
+
 Several areas can be cleaned up to make mandoc even faster.  These are 
 
 - improve hashing mechanism for macros (quite important: performance)
--
 To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv