From: schwarze@mdocml.bsd.lv
To: source@mdocml.bsd.lv
Subject: mdocml: No need to assert() that a pointer is non-null right before
Date: Fri, 10 Oct 2014 10:02:02 -0400 (EDT) [thread overview]
Message-ID: <201410101402.s9AE22nx015166@krisdoz.my.domain> (raw)
Log Message:
-----------
No need to assert() that a pointer is non-null right before dereferencing it.
The assert message contains no more information than the segfault.
Modified Files:
--------------
mdocml:
eqn.c
Revision Data
-------------
Index: eqn.c
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/eqn.c,v
retrieving revision 1.49
retrieving revision 1.50
diff -Leqn.c -Leqn.c -u -p -r1.49 -r1.50
--- eqn.c
+++ eqn.c
@@ -537,10 +537,7 @@ eqn_box_alloc(struct eqn_node *ep, struc
bp->expectargs = UINT_MAX;
bp->size = ep->gsize;
- assert(NULL != parent);
-
if (NULL != parent->first) {
- assert(NULL != parent->last);
parent->last->next = bp;
bp->prev = parent->last;
} else
--
To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv
reply other threads:[~2014-10-10 14:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201410101402.s9AE22nx015166@krisdoz.my.domain \
--to=schwarze@mdocml.bsd.lv \
--cc=source@mdocml.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).