mdocml: To remove the const qualifier from a pointer to an object -

mdocml: To remove the const qualifier from a pointer to an object -

[schwarze]

Log Message:
-----------
To remove the const qualifier from a pointer to an object - either 
because we know it is actually mutable or because we are passing
it to a function that doesn't accept a const object but won't
actually attempt to modify it - simply casting from (const type *)
to (type *) is legal C and clearly expresses the intent.  
So get rid of the obfuscating UNCONST macro.
Basic idea discussed with guenther@.

Modified Files:
--------------
    mdocml:
        main.c
        main.h

Revision Data
-------------
Index: main.h
===================================================================
RCS file: /home/cvs/mdocml/mdocml/main.h,v
retrieving revision 1.25
retrieving revision 1.26
diff -Lmain.h -Lmain.h -u -p -r1.25 -r1.26
--- main.h
+++ main.h
@@ -16,8 +16,6 @@
  * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-#define	UNCONST(a)	((void *)(uintptr_t)(const void *)(a))
-
 struct	roff_man;
 struct	manoutput;
 
Index: main.c
===================================================================
RCS file: /home/cvs/mdocml/mdocml/main.c,v
retrieving revision 1.271
retrieving revision 1.272
diff -Lmain.c -Lmain.c -u -p -r1.271 -r1.272
--- main.c
+++ main.c
@@ -980,7 +980,7 @@ woptions(struct curparse *curp, char *ar
 
 	while (*arg) {
 		o = arg;
-		switch (getsubopt(&arg, UNCONST(toks), &v)) {
+		switch (getsubopt(&arg, (char * const *)toks, &v)) {
 		case 0:
 			curp->wstop = 1;
 			break;
--
 To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv

Re: mdocml: To remove the const qualifier from a pointer to an object -

[Joerg Sonnenberger]

On Fri, Jul 15, 2016 at 02:33:31PM -0500, schwarze@mdocml.bsd.lv wrote:
> To remove the const qualifier from a pointer to an object - either 
> because we know it is actually mutable or because we are passing
> it to a function that doesn't accept a const object but won't
> actually attempt to modify it - simply casting from (const type *)
> to (type *) is legal C and clearly expresses the intent.  
> So get rid of the obfuscating UNCONST macro.
> Basic idea discussed with guenther@.

This is completely wrong and a clear regression. The macro exists for
two reasons:
(1) It makes auditing easier by giving something simple to look for.
(2) The macro actually stopped -Wcast warnings. The replacement does
not.

Joerg
--
 To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv