From: schwarze@mandoc.bsd.lv
To: source@mandoc.bsd.lv
Subject: mandoc: Adjust a column number in an error message after the
Date: Thu, 19 May 2022 11:09:56 -0500 (EST) [thread overview]
Message-ID: <336533e67c453633@mandoc.bsd.lv> (raw)
Log Message:
-----------
Adjust a column number in an error message
after the roff_expand() reorganization in roff.c rev. 1.388.
The new parsing direction has two effects:
1. Correct output when a line contains more than one expanding
escape sequence that has a side effect.
2. Column numbers in diagnostic messages now report the changed
column numbers after any expansions left of them have taken place;
in the past, column numbers refered to the original input line.
Arguably, item 2 was a bit better in its old state, but slightly
less helpful diagnostics are a small price to pay for correct
output. Besides, when the expansion of user-defined strings or
macros is involved, in many cases, mandoc(1) is already unable to
report meaningful line and column numbers, so item 2 is not a
noteworthy regression. The effort and code complication for fixing
that would probably be excessive, in particular since well-written
manual pages are not supposed to use such features in the first place.
Modified Files:
--------------
mandoc/regress/roff/return:
basic.out_lint
Revision Data
-------------
Index: basic.out_lint
===================================================================
RCS file: /home/cvs/mandoc/mandoc/regress/roff/return/basic.out_lint,v
retrieving revision 1.1
retrieving revision 1.2
diff -Lregress/roff/return/basic.out_lint -Lregress/roff/return/basic.out_lint -u -p -r1.1 -r1.2
--- regress/roff/return/basic.out_lint
+++ regress/roff/return/basic.out_lint
@@ -1,3 +1,3 @@
mandoc: basic.in:10:2: ERROR: ignoring request outside macro: return
-mandoc: basic.in:18:32: ERROR: using macro argument outside macro: \$1
+mandoc: basic.in:18:28: ERROR: using macro argument outside macro: \$1
mandoc: basic.in:21:2: ERROR: ignoring request outside macro: return
--
To unsubscribe send an email to source+unsubscribe@mandoc.bsd.lv
reply other threads:[~2022-05-19 16:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=336533e67c453633@mandoc.bsd.lv \
--to=schwarze@mandoc.bsd.lv \
--cc=source@mandoc.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).