source@mandoc.bsd.lv
 help / color / mirror / Atom feed
* mandoc: Adjust a column number in an error message after the
@ 2022-05-19 16:09 schwarze
  0 siblings, 0 replies; only message in thread
From: schwarze @ 2022-05-19 16:09 UTC (permalink / raw)
  To: source

Log Message:
-----------
Adjust a column number in an error message
after the roff_expand() reorganization in roff.c rev. 1.388.

The new parsing direction has two effects:
1. Correct output when a line contains more than one expanding 
escape sequence that has a side effect.
2. Column numbers in diagnostic messages now report the changed
column numbers after any expansions left of them have taken place;
in the past, column numbers refered to the original input line.

Arguably, item 2 was a bit better in its old state, but slightly
less helpful diagnostics are a small price to pay for correct
output.  Besides, when the expansion of user-defined strings or
macros is involved, in many cases, mandoc(1) is already unable to
report meaningful line and column numbers, so item 2 is not a
noteworthy regression.  The effort and code complication for fixing
that would probably be excessive, in particular since well-written
manual pages are not supposed to use such features in the first place.

Modified Files:
--------------
    mandoc/regress/roff/return:
        basic.out_lint

Revision Data
-------------
Index: basic.out_lint
===================================================================
RCS file: /home/cvs/mandoc/mandoc/regress/roff/return/basic.out_lint,v
retrieving revision 1.1
retrieving revision 1.2
diff -Lregress/roff/return/basic.out_lint -Lregress/roff/return/basic.out_lint -u -p -r1.1 -r1.2
--- regress/roff/return/basic.out_lint
+++ regress/roff/return/basic.out_lint
@@ -1,3 +1,3 @@
 mandoc: basic.in:10:2: ERROR: ignoring request outside macro: return
-mandoc: basic.in:18:32: ERROR: using macro argument outside macro: \$1
+mandoc: basic.in:18:28: ERROR: using macro argument outside macro: \$1
 mandoc: basic.in:21:2: ERROR: ignoring request outside macro: return
--
 To unsubscribe send an email to source+unsubscribe@mandoc.bsd.lv


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-05-19 16:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-19 16:09 mandoc: Adjust a column number in an error message after the schwarze

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).