From: schwarze@mandoc.bsd.lv
To: source@mandoc.bsd.lv
Subject: mandoc: Printing "BASE:" in messages about violations of base system
Date: Tue, 4 Jul 2017 09:41:08 -0500 (EST) [thread overview]
Message-ID: <3457771590981291247.enqueue@fantadrom.bsd.lv> (raw)
Log Message:
-----------
Printing "BASE:" in messages about violations of base system conventions
is confusing, simply print "STYLE:", which is intuitive and does not
sound excessively alarming; suggested by jmc@, OK tedu@ jmc@.
Modified Files:
--------------
mandoc:
main.c
mandoc.1
read.c
Revision Data
-------------
Index: read.c
===================================================================
RCS file: /home/cvs/mandoc/mandoc/read.c,v
retrieving revision 1.187
retrieving revision 1.188
diff -Lread.c -Lread.c -u -p -r1.187 -r1.188
--- read.c
+++ read.c
@@ -75,7 +75,7 @@ static void mparse_parse_buffer(struct
static const enum mandocerr mandoclimits[MANDOCLEVEL_MAX] = {
MANDOCERR_OK,
- MANDOCERR_STYLE,
+ MANDOCERR_OK,
MANDOCERR_WARNING,
MANDOCERR_ERROR,
MANDOCERR_UNSUPP,
Index: main.c
===================================================================
RCS file: /home/cvs/mandoc/mandoc/main.c,v
retrieving revision 1.298
retrieving revision 1.299
diff -Lmain.c -Lmain.c -u -p -r1.298 -r1.299
--- main.c
+++ main.c
@@ -1089,8 +1089,7 @@ mmsg(enum mandocerr t, enum mandoclevel
if (line)
fprintf(stderr, "%d:%d:", line, col + 1);
- fprintf(stderr, " %s",
- t < MANDOCERR_STYLE ? "BASE" : mparse_strlevel(lvl));
+ fprintf(stderr, " %s", mparse_strlevel(lvl));
if ((mparse_msg = mparse_strerror(t)) != NULL)
fprintf(stderr, ": %s", mparse_msg);
Index: mandoc.1
===================================================================
RCS file: /home/cvs/mandoc/mandoc/mandoc.1,v
retrieving revision 1.213
retrieving revision 1.214
diff -Lmandoc.1 -Lmandoc.1 -u -p -r1.213 -r1.214
--- mandoc.1
+++ mandoc.1
@@ -762,6 +762,12 @@ A convertion used in the base system of
is not adhered to.
These are not markup mistakes, and neither the quality of formatting
nor portability are in danger.
+Messages of the
+.Cm base
+level are printed with the more intuitive
+.Cm style
+.Ar level
+tag.
.El
.Pp
Messages of the
--
To unsubscribe send an email to source+unsubscribe@mandoc.bsd.lv
reply other threads:[~2017-07-04 14:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3457771590981291247.enqueue@fantadrom.bsd.lv \
--to=schwarze@mandoc.bsd.lv \
--cc=source@mandoc.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).