source@mandoc.bsd.lv
 help / color / mirror / Atom feed
From: Kristaps Dzonsons <kristaps@bsd.lv>
To: source@mdocml.bsd.lv, Ingo Schwarze <schwarze@usta.de>
Subject: Re: mdocml: Store page titles in the correct case, and by default, only put
Date: Sat, 26 Nov 2011 12:54:19 +0100	[thread overview]
Message-ID: <4ED0D36B.2080503@bsd.lv> (raw)
In-Reply-To: <201111261123.pAQBNvRl005038@krisdoz.my.domain>

On 26/11/2011 12:23, schwarze@mdocml.bsd.lv wrote:
> Log Message:
> -----------
> Store page titles in the correct case, and by default, only
> put stuff into the database that man(1) will be able to retrieve.
> However, support an option to use all directories and files.
> feedback and ok  kristaps@

Ingo,

Some post-checkin comments.  First, I think we can make verbose and 
use_all into global statics, as they don't change and we're just 
cluttering the function prototypes with them.  No?  And second, in the 
manual, can you put the default usage following the arguments?

  Its arguments are as follows:

  -a    blah blah

  -b    blah blah

  By default, foo does this and that...

This is much easier to read and doesn't require that operators read each 
option to understand the defaults.

Thanks,

Kristaps


--
 To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv

      reply	other threads:[~2011-11-26 11:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-26 11:23 schwarze
2011-11-26 11:54 ` Kristaps Dzonsons [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED0D36B.2080503@bsd.lv \
    --to=kristaps@bsd.lv \
    --cc=schwarze@usta.de \
    --cc=source@mdocml.bsd.lv \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).