From: schwarze@mandoc.bsd.lv
To: source@mandoc.bsd.lv
Subject: mandoc: Ouch, fix previous: In the edge case of a single-character
Date: Fri, 16 Mar 2018 15:42:12 -0500 (EST) [thread overview]
Message-ID: <84f50dfd5e5d224e@fantadrom.bsd.lv> (raw)
Log Message:
-----------
Ouch, fix previous: In the edge case of a single-character string
containing nothing but a single hyphen, the pointer got incremented
twice at one point, causing a read overrun found by naddy@.
Modified Files:
--------------
mandoc:
mdoc_validate.c
Revision Data
-------------
Index: mdoc_validate.c
===================================================================
RCS file: /home/cvs/mandoc/mandoc/mdoc_validate.c,v
retrieving revision 1.355
retrieving revision 1.356
diff -Lmdoc_validate.c -Lmdoc_validate.c -u -p -r1.355 -r1.356
--- mdoc_validate.c
+++ mdoc_validate.c
@@ -412,8 +412,9 @@ check_text_em(struct roff_man *mdoc, int
/* Look for em-dashes wrongly encoded as "--". */
for (cp = p; *cp != '\0'; cp++) {
- if (*cp != '-' || *++cp != '-')
+ if (cp[0] != '-' || cp[1] != '-')
continue;
+ cp++;
/* Skip input sequences of more than two '-'. */
--
To unsubscribe send an email to source+unsubscribe@mandoc.bsd.lv
reply other threads:[~2018-03-16 20:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84f50dfd5e5d224e@fantadrom.bsd.lv \
--to=schwarze@mandoc.bsd.lv \
--cc=source@mandoc.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).