From: schwarze@mandoc.bsd.lv
To: source@mandoc.bsd.lv
Subject: cvsweb: Partial revert of rev.
Date: Thu, 7 Nov 2019 12:18:53 -0500 (EST) [thread overview]
Message-ID: <8d0762254e5f4beb@mandoc.bsd.lv> (raw)
Log Message:
-----------
Partial revert of rev. 3.119.2.15:
The variables $barequery and $query typically contain literal "&"
characters separating multiple variable assignments; the cvsweb.cgi
program itself constructs them that way near the beginning of the
main program. So they must not be passed through htmlquote() or
the URIs in question get broken.
I will have to fix the XSS issues differently.
Tags:
----
FreeBSD-cvsweb-2_0-branch
Modified Files:
--------------
cvsweb:
cvsweb.cgi
Revision Data
-------------
Index: cvsweb.cgi
===================================================================
RCS file: /home/cvs/mandoc/cvsweb/cvsweb.cgi,v
retrieving revision 3.119.2.20
retrieving revision 3.119.2.21
diff -Lcvsweb.cgi -Lcvsweb.cgi -u -p -r3.119.2.20 -r3.119.2.21
--- cvsweb.cgi
+++ cvsweb.cgi
@@ -2608,11 +2608,8 @@ sub printLog($;$) {
print " - ";
print &link(
'annotate',
- sprintf(
- '%s/%s?annotate=%s%s', $scriptname,
- urlencode($where), $_,
- htmlquote($barequery)
- )
+ sprintf('%s/%s?annotate=%s%s', $scriptname,
+ urlencode($where), $_, $barequery)
);
}
@@ -2622,10 +2619,8 @@ sub printLog($;$) {
print " - ";
print &link(
'[select for diffs]',
- sprintf(
- '%s?r1=%s%s', $scriptwhere,
- $_, htmlquote($barequery)
- )
+ sprintf('%s?r1=%s%s', $scriptwhere,
+ $_, $barequery)
);
} else {
print " - <b>[selected]</b>";
@@ -3267,7 +3262,7 @@ sub clickablePath($$) {
join ('', $scriptname,
urlencode($wherepath),
(!$last || $lastslash ? '/' : ''),
- htmlquote($query),
+ $query,
(!$last || $lastslash ? "#dirlist" : "")
));
} else { # do not make a link to the current dir
--
To unsubscribe send an email to source+unsubscribe@mandoc.bsd.lv
reply other threads:[~2019-11-07 17:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d0762254e5f4beb@mandoc.bsd.lv \
--to=schwarze@mandoc.bsd.lv \
--cc=source@mandoc.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).