From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from localhost (mandoc.bsd.lv [local])
	by mandoc.bsd.lv (OpenSMTPD) with ESMTPA id 66ac3ff7
	for <source@mandoc.bsd.lv>;
	Fri, 29 Nov 2019 13:16:19 -0500 (EST)
Date: Fri, 29 Nov 2019 13:16:19 -0500 (EST)
X-Mailinglist: mandoc-source
Reply-To: source@mandoc.bsd.lv
MIME-Version: 1.0
From: schwarze@mandoc.bsd.lv
To: source@mandoc.bsd.lv
Subject: cvsweb: Delete $showfunc configuration variable.
X-Mailer: activitymail 1.26, http://search.cpan.org/dist/activitymail/
Content-Type: text/plain; charset=utf-8
Message-ID: <8d079b2e4f50d5ba@mandoc.bsd.lv>

Log Message:
-----------
Delete $showfunc configuration variable.
There is really no point in switching off diff(1) -p.

Modified Files:
--------------
    cvsweb:
        cvsweb.cgi
        cvsweb.conf

Revision Data
-------------
Index: cvsweb.cgi
===================================================================
RCS file: /home/cvs/mandoc/cvsweb/cvsweb.cgi,v
retrieving revision 4.34
retrieving revision 4.35
diff -Lcvsweb.cgi -Lcvsweb.cgi -u -p -r4.34 -r4.35
--- cvsweb.cgi
+++ cvsweb.cgi
@@ -68,8 +68,7 @@ use vars qw (
   $bylog $byfile $defaultDiffType $logsort $cvstree $cvsroot
   $charset $output_filter %CMD $allow_compress $backicon $diricon $fileicon
   $fullname $logo $defaulttitle $address $binfileicon $iconsdir
-  $shortLogLen $show_author
-  $hr_breakable $showfunc $hr_ignwhite $hr_ignkeysubst
+  $shortLogLen $show_author $hr_breakable $hr_ignwhite $hr_ignkeysubst
   $inputTextSize $mime_types $allow_annotate $allow_markup $allow_mailtos
   $allow_log_extra $allow_dir_extra $allow_source_extra
   $edit_option_form
@@ -203,7 +202,7 @@ $config = '/conf/cvsweb/cvsweb.conf';
 
 $logo = $defaulttitle =
   $address = $shortLogLen = $show_author =
-  $hr_breakable = $showfunc = $hr_ignwhite =
+  $hr_breakable = $hr_ignwhite =
   $hr_ignkeysubst = $inputTextSize = $mime_types = $allow_annotate =
   $allow_markup = $allow_compress = $edit_option_form =
   $show_subdir_lastmod = $show_log_in_markup = $preformat_in_markup =
@@ -2127,7 +2126,7 @@ sub doDiff($$$$$$)
   my $human_readable = $difftype->{colored};
 
   # Apply special diff options.
-  push @difftype, '-p' if $showfunc;
+  push @difftype, '-p';
 
   if ($human_readable) {
     push(@difftype, '-w')  if $hr_ignwhite;
Index: cvsweb.conf
===================================================================
RCS file: /home/cvs/mandoc/cvsweb/cvsweb.conf,v
retrieving revision 4.22
retrieving revision 4.23
diff -Lcvsweb.conf -Lcvsweb.conf -u -p -r4.22 -r4.23
--- cvsweb.conf
+++ cvsweb.conf
@@ -168,11 +168,6 @@ $use_descriptions = 0;
 #
 $hr_breakable = 1;
 
-# Print function names in diffs (unified and context only).
-# See the -p option in the diff(1) man page.
-#
-$showfunc = 1;
-
 # Ignore whitespace in human readable diffs? ('-w' option to diff)
 #
 $hr_ignwhite = 0;
--
 To unsubscribe send an email to source+unsubscribe@mandoc.bsd.lv