source@mandoc.bsd.lv
 help / color / mirror / Atom feed
From: schwarze@mandoc.bsd.lv
To: source@mandoc.bsd.lv
Subject: cvsweb: drop the completely pointless $inputTextSize config variable
Date: Fri, 29 Nov 2019 13:33:54 -0500 (EST)	[thread overview]
Message-ID: <8d079b58360d0418@mandoc.bsd.lv> (raw)

Log Message:
-----------
drop the completely pointless $inputTextSize config variable

Modified Files:
--------------
    cvsweb:
        cvsweb.cgi
        cvsweb.conf

Revision Data
-------------
Index: cvsweb.cgi
===================================================================
RCS file: /home/cvs/mandoc/cvsweb/cvsweb.cgi,v
retrieving revision 4.35
retrieving revision 4.36
diff -Lcvsweb.cgi -Lcvsweb.cgi -u -p -r4.35 -r4.36
--- cvsweb.cgi
+++ cvsweb.cgi
@@ -69,7 +69,7 @@ use vars qw (
   $charset $output_filter %CMD $allow_compress $backicon $diricon $fileicon
   $fullname $logo $defaulttitle $address $binfileicon $iconsdir
   $shortLogLen $show_author $hr_breakable $hr_ignwhite $hr_ignkeysubst
-  $inputTextSize $mime_types $allow_annotate $allow_markup $allow_mailtos
+  $mime_types $allow_annotate $allow_markup $allow_mailtos
   $allow_log_extra $allow_dir_extra $allow_source_extra
   $edit_option_form
   $show_subdir_lastmod $show_log_in_markup $preformat_in_markup
@@ -203,7 +203,7 @@ $config = '/conf/cvsweb/cvsweb.conf';
 $logo = $defaulttitle =
   $address = $shortLogLen = $show_author =
   $hr_breakable = $hr_ignwhite =
-  $hr_ignkeysubst = $inputTextSize = $mime_types = $allow_annotate =
+  $hr_ignkeysubst = $mime_types = $allow_annotate =
   $allow_markup = $allow_compress = $edit_option_form =
   $show_subdir_lastmod = $show_log_in_markup = $preformat_in_markup =
   $tabstop = $use_moddate = $gzip_open = $DEBUG =
@@ -2929,8 +2929,8 @@ EOF
   my $diffrev = defined($input{r1}) ?
     $input{r1} : $revdisplayorder[$#revdisplayorder];
 
-  printf(<<EOF, $inputTextSize, $diffrev);
-<input type="text" size="%s" name="tr1" value="%s" onchange="this.form.r1.selectedIndex=0" />
+  printf(<<EOF, $diffrev);
+<input type="text" size="12" name="tr1" value="%s" onchange="this.form.r1.selectedIndex=0" />
 </td>
 <td></td>
 </tr>
@@ -2946,8 +2946,8 @@ EOF
 
   $diffrev = defined($input{r2}) ? $input{r2} : $revdisplayorder[0];
 
-  printf(<<EOF, $inputTextSize, $diffrev, $scriptwhere);
-<input type="text" size="%s" name="tr2" value="%s" onchange="this.form.r2.selectedIndex=0" />
+  printf(<<EOF, $diffrev, $scriptwhere);
+<input type="text" size="12" name="tr2" value="%s" onchange="this.form.r2.selectedIndex=0" />
 </td>
 <td><input type="submit" value="Get Diffs" accesskey="G" /></td>
 </tr>
Index: cvsweb.conf
===================================================================
RCS file: /home/cvs/mandoc/cvsweb/cvsweb.conf,v
retrieving revision 4.23
retrieving revision 4.24
diff -Lcvsweb.conf -Lcvsweb.conf -u -p -r4.23 -r4.24
--- cvsweb.conf
+++ cvsweb.conf
@@ -177,10 +177,6 @@ $hr_ignwhite = 0;
 #
 $hr_ignkeysubst = 1;
 
-# The width of the textinput of the "request diff" form.
-#
-$inputTextSize = 12;
-
 # Custom per MIME type diff tools, used for comparing binary files such as
 # spreadsheets, images etc.  Each key is a MIME type in lowercase.
 # Each value is an array ref of available diff tools for that type, each of
--
 To unsubscribe send an email to source+unsubscribe@mandoc.bsd.lv

                 reply	other threads:[~2019-11-29 18:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d079b58360d0418@mandoc.bsd.lv \
    --to=schwarze@mandoc.bsd.lv \
    --cc=source@mandoc.bsd.lv \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).