source@mandoc.bsd.lv
 help / color / mirror / Atom feed
* mandoc: do not use the sed(1) -i option, it is not portable; issue found
@ 2021-09-19 12:16 schwarze
  0 siblings, 0 replies; only message in thread
From: schwarze @ 2021-09-19 12:16 UTC (permalink / raw)
  To: source

Log Message:
-----------
do not use the sed(1) -i option, it is not portable;
issue found on Oracle Solaris 11

Modified Files:
--------------
    mandoc/regress:
        regress.pl

Revision Data
-------------
Index: regress.pl
===================================================================
RCS file: /home/cvs/mandoc/mandoc/regress/regress.pl,v
retrieving revision 1.15
retrieving revision 1.16
diff -Lregress/regress.pl -Lregress/regress.pl -u -p -r1.15 -r1.16
--- regress/regress.pl
+++ regress/regress.pl
@@ -2,7 +2,7 @@
 #
 # $Id$
 #
-# Copyright (c) 2017, 2018, 2019, 2020 Ingo Schwarze <schwarze@openbsd.org>
+# Copyright (c) 2017,2018,2019,2020,2021 Ingo Schwarze <schwarze@openbsd.org>
 #
 # Permission to use, copy, modify, and distribute this software for any
 # purpose with or without fee is hereby granted, provided that the above
@@ -261,6 +261,7 @@ for my $test (@regress_tests) {
 	my $o = "$test->{NAME}.mandoc_ascii";
 	my $w = "$test->{NAME}.out_ascii";
 	my $to = "$test->{NAME}.mandoc_tag";
+	my $tos = "$test->{NAME}.mandoc_tag_s";
 	my $tw = "$test->{NAME}.out_tag";
 	my $diff_ascii;
 	if ($targets{tag} && $tag_tests{$test->{NAME}} &&
@@ -273,8 +274,8 @@ for my $test (@regress_tests) {
 		print "@cmd\n" if $targets{verbose};
 		system @cmd
 		    and fail $test->{NAME}, 'tag:man';
-		system qw(sed -i), 's/ .*\// /', $to;
-		system @diff, $tw, $to
+		system "sed 's: .*/: :' $to > $tos";
+		system @diff, $tw, $tos
 		    and fail $test->{NAME}, 'tag:diff';
 		print "." unless $targets{verbose};
 		$diff_ascii = $targets{ascii};
@@ -309,8 +310,8 @@ for my $test (@regress_tests) {
 		print "." unless $targets{verbose};
 	}
 	if ($targets{clean}) {
-		print "rm $o $to $m $mo\n" if $targets{verbose};
-		$count_rm += unlink $o, $to, $m, $mo;
+		print "rm $o $to $tos $m $mo\n" if $targets{verbose};
+		$count_rm += unlink $o, $to, $tos, $m, $mo;
 	}
 }
 if ($targets{ascii} || $targets{tag} || $targets{man}) {
--
 To unsubscribe send an email to source+unsubscribe@mandoc.bsd.lv


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-09-19 12:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-19 12:16 mandoc: do not use the sed(1) -i option, it is not portable; issue found schwarze

source@mandoc.bsd.lv

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.vuxu.org/mandoc-source

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 mandoc-source mandoc-source/ https://inbox.vuxu.org/mandoc-source \
		source@mandoc.bsd.lv
	public-inbox-index mandoc-source

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.mandoc.source


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git