help / color / mirror / Atom feed
* mandoc: Do not leak 64 bytes of heap memory every time a manual page
@ 2021-10-04 10:12 schwarze
  0 siblings, 0 replies; only message in thread
From: schwarze @ 2021-10-04 10:12 UTC (permalink / raw)
  To: source

Log Message:
Do not leak 64 bytes of heap memory every time a manual page calls
a user-defined macro.  Calls of standard mdoc(7) and man(7) macros
were unaffected, so the effect on OpenBSD manual pages was small,
about 80 Kilobytes grand total for a full run of "makewhatis

Argument expansion contexts for user-defined macros are stored on
a stack that grows as needed if calls of user-defined macros are
nested or recursive.  Individual stack entries contain dynamically
allocated arrays of pointers to arguments; these argument arrays
also grow as needed if user-defined macros take more than eight
arguments.  The mistake was that argument arrays of already
initialized expansion contexts were leaked rather than reused on
subsequent macro calls.

I found this issue in a systematic hunt for memory leaks after
Michael <Stapelberg at Debian> reported memory exhaustion problems
on the production server  This sub-Megabyte
leak is not the cause of Michael's trouble, though, where Gigabytes
of memory are being wasted.  We are still investigating whether the
original problem may be related to his supervisor process, which is
written in Go, rather than to mandoc.

Modified Files:

Revision Data
Index: roff.c
RCS file: /home/cvs/mandoc/mandoc/roff.c,v
retrieving revision 1.378
retrieving revision 1.379
diff -Lroff.c -Lroff.c -u -p -r1.378 -r1.379
--- roff.c
+++ roff.c
@@ -3949,9 +3949,7 @@ roff_userdef(ROFF_ARGS)
 		r->mstacksz += 8;
 	ctx = r->mstack + r->mstackpos;
-	ctx->argsz = 0;
 	ctx->argc = 0;
-	ctx->argv = NULL;
 	 * Collect pointers to macro argument strings,
 To unsubscribe send an email to

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-10-04 10:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-04 10:12 mandoc: Do not leak 64 bytes of heap memory every time a manual page schwarze

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).