From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from localhost (fantadrom.bsd.lv [local]) by fantadrom.bsd.lv (OpenSMTPD) with ESMTPA id cc407dd6 for ; Mon, 4 Mar 2019 06:40:39 -0500 (EST) Date: Mon, 4 Mar 2019 06:40:39 -0500 (EST) X-Mailinglist: mandoc-source Reply-To: source@mandoc.bsd.lv MIME-Version: 1.0 From: schwarze@mandoc.bsd.lv To: source@mandoc.bsd.lv Subject: mandoc: Fix the last straggler where the struct roff_node "line" member X-Mailer: activitymail 1.26, http://search.cpan.org/dist/activitymail/ Content-Type: text/plain; charset=utf-8 Message-ID: Log Message: ----------- Fix the last straggler where the struct roff_node "line" member was abused to detect an input line break; instead, use the NODE_LINE flag to improve robustness. Modified Files: -------------- mandoc: TODO mdoc_validate.c Revision Data ------------- Index: mdoc_validate.c =================================================================== RCS file: /home/cvs/mandoc/mandoc/mdoc_validate.c,v retrieving revision 1.369 retrieving revision 1.370 diff -Lmdoc_validate.c -Lmdoc_validate.c -u -p -r1.369 -r1.370 --- mdoc_validate.c +++ mdoc_validate.c @@ -1581,7 +1581,7 @@ post_it(POST_ARGS) mandoc_msg(MANDOCERR_BL_COL, nit->line, nit->pos, "%d columns, %d cells", cols, i); else if (nit->head->next->child != NULL && - nit->head->next->child->line > nit->line) + nit->head->next->child->flags & NODE_LINE) mandoc_msg(MANDOCERR_IT_NOARG, nit->line, nit->pos, "Bl -column It"); break; Index: TODO =================================================================== RCS file: /home/cvs/mandoc/mandoc/TODO,v retrieving revision 1.287 retrieving revision 1.288 diff -LTODO -LTODO -u -p -r1.287 -r1.288 --- TODO +++ TODO @@ -523,10 +523,6 @@ are mere guesses, and some may be wrong. Found by Aaron M. Ucko in the GNU Hurd via Bdale Garbee, https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=829624 -- We use the input line number at several places to distinguish - same-line from different-line input. That plainly doesn't work - with user-defined macros, leading to random breakage. - - Is it possible to further simplify ENDBODY_SPACE? - Find better ways to prevent endless loops -- To unsubscribe send an email to source+unsubscribe@mandoc.bsd.lv