From: schwarze@mandoc.bsd.lv
To: source@mandoc.bsd.lv
Subject: docbook2mdoc: do not access null pointers when the document element is
Date: Sun, 7 Apr 2019 12:43:06 -0500 (EST) [thread overview]
Message-ID: <e3fd724992e20014@fantadrom.bsd.lv> (raw)
Log Message:
-----------
do not access null pointers when the document element is <title>
Modified Files:
--------------
docbook2mdoc:
docbook2mdoc.c
Revision Data
-------------
Index: docbook2mdoc.c
===================================================================
RCS file: /home/cvs/mdocml/docbook2mdoc/docbook2mdoc.c,v
retrieving revision 1.96
retrieving revision 1.97
diff -Ldocbook2mdoc.c -Ldocbook2mdoc.c -u -p -r1.96 -r1.97
--- docbook2mdoc.c
+++ docbook2mdoc.c
@@ -103,10 +103,12 @@ pnode_printpara(struct format *p, struct
{
struct pnode *pp;
- if ((pp = TAILQ_PREV(pn, pnodeq, child)) == NULL &&
- (pp = pn->parent) == NULL)
+ if (pn->parent == NULL)
return;
+ if ((pp = TAILQ_PREV(pn, pnodeq, child)) == NULL)
+ pp = pn->parent;
+
switch (pp->node) {
case NODE_ENTRY:
case NODE_LISTITEM:
@@ -920,7 +922,8 @@ pnode_print(struct format *p, struct pno
pnode_printtgroup(p, pn);
break;
case NODE_TITLE:
- if (pn->parent->node == NODE_BOOKINFO) {
+ if (pn->parent != NULL &&
+ pn->parent->node == NODE_BOOKINFO) {
macro_open(p, "Nd");
break;
}
@@ -1045,7 +1048,8 @@ pnode_print(struct format *p, struct pno
macro_line(p, "Ed");
break;
case NODE_TITLE:
- if (pn->parent->node == NODE_BOOKINFO)
+ if (pn->parent != NULL &&
+ pn->parent->node == NODE_BOOKINFO)
macro_line(p, "Sh AUTHORS");
break;
default:
--
To unsubscribe send an email to source+unsubscribe@mandoc.bsd.lv
reply other threads:[~2019-04-07 17:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3fd724992e20014@fantadrom.bsd.lv \
--to=schwarze@mandoc.bsd.lv \
--cc=source@mandoc.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).