source@mandoc.bsd.lv
 help / color / mirror / Atom feed
* mandoc: Explicitly state that the cases in the inner switch in
@ 2019-06-03 20:24 schwarze
  0 siblings, 0 replies; only message in thread
From: schwarze @ 2019-06-03 20:24 UTC (permalink / raw)
  To: source

Log Message:
-----------
Explicitly state that the cases in the inner switch in term_fill()
are exhaustive.  While there is no bug, being explicit has no downside
is is potentially safer for the future.

Michal Nowak <mnowak at startmail dot com> reported that gcc 4.4.4
and 7.4.0 on illumos throw -Wuninitialized false positives.

Modified Files:
--------------
    mandoc:
        term.c

Revision Data
-------------
Index: term.c
===================================================================
RCS file: /home/cvs/mandoc/mandoc/term.c,v
retrieving revision 1.280
retrieving revision 1.281
diff -Lterm.c -Lterm.c -u -p -r1.280 -r1.281
--- term.c
+++ term.c
@@ -281,6 +281,8 @@ term_fill(struct termp *p, size_t *nbr, 
 			case ASCII_BREAK:
 				vn = vis;
 				break;
+			default:
+				abort();
 			}
 			/* Can break at the end of a word. */
 			if (breakline || vn > vtarget)
--
 To unsubscribe send an email to source+unsubscribe@mandoc.bsd.lv

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-06-03 20:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-03 20:24 mandoc: Explicitly state that the cases in the inner switch in schwarze

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).