From: "Anthony J. Bentley" <anthony@anjbe.name>
To: Ingo Schwarze <schwarze@usta.de>
Cc: tech@mandoc.bsd.lv
Subject: Re: Content-Security-Policy for man.cgi
Date: Sun, 10 Nov 2019 13:09:05 -0700 [thread overview]
Message-ID: <1076-1573416545.590100@piVC.Y-1h.zrhB> (raw)
In-Reply-To: <20191110174755.GA11024@athene.usta.de>
Hi Ingo,
Ingo Schwarze writes:
> > It might be worth replacing these with stylesheet references for the
> > sake of having a CSP strict enough to prevent malicious inline CSS in
> > the manual body. But if not, we'll have to broaden the policy. Even a
> > broad CSS policy is better because we still completely block JavaScript.
>
> I think completely getting rid of style= isn't that hard, but i won't
> work too much on mandoc during a ports hackathon - so i have taken
> a TODO note for now (see below).
Then here's the new diff. (I removed the space after the semicolon
as it's optional.)
Index: cgi.c
===================================================================
RCS file: /cvs/src/usr.bin/mandoc/cgi.c,v
retrieving revision 1.106
diff -u -p -r1.106 cgi.c
--- cgi.c 1 Oct 2019 17:54:04 -0000 1.106
+++ cgi.c 10 Nov 2019 20:07:39 -0000
@@ -336,6 +336,8 @@ resp_begin_http(int code, const char *ms
printf("Content-Type: text/html; charset=utf-8\r\n"
"Cache-Control: no-cache\r\n"
+ "Content-Security-Policy: default-src 'none';"
+ "style-src 'self' 'unsafe-inline'\r\n"
"Pragma: no-cache\r\n"
"\r\n");
--
To unsubscribe send an email to tech+unsubscribe@mandoc.bsd.lv
next prev parent reply other threads:[~2019-11-10 20:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-10 8:59 Anthony J. Bentley
2019-11-10 10:22 ` Ingo Schwarze
2019-11-10 13:02 ` Anthony J. Bentley
2019-11-10 17:47 ` Ingo Schwarze
2019-11-10 20:09 ` Anthony J. Bentley [this message]
2019-11-10 20:57 ` Ingo Schwarze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1076-1573416545.590100@piVC.Y-1h.zrhB \
--to=anthony@anjbe.name \
--cc=schwarze@usta.de \
--cc=tech@mandoc.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).