From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp1.rz.uni-karlsruhe.de (Debian-exim@smtp1.rz.uni-karlsruhe.de [129.13.185.217])
	by krisdoz.my.domain (8.14.3/8.14.3) with ESMTP id o4O2OwEA020320
	for <tech@mdocml.bsd.lv>; Sun, 23 May 2010 20:24:59 -0600 (MDT)
Received: from hekate.usta.de (asta-nat.asta.uni-karlsruhe.de [172.22.63.82])
	by smtp1.rz.uni-karlsruhe.de with esmtp (Exim 4.63 #1)
	id 1OGNLb-0005R3-JN; Mon, 24 May 2010 04:24:57 +0200
Received: from donnerwolke.usta.de ([172.24.96.3])
	by hekate.usta.de with esmtp (Exim 4.71)
	(envelope-from <schwarze@usta.de>)
	id 1OGNLb-0003h3-IL
	for tech@mdocml.bsd.lv; Mon, 24 May 2010 04:24:55 +0200
Received: from iris.usta.de ([172.24.96.5] helo=usta.de)
	by donnerwolke.usta.de with esmtp (Exim 4.69)
	(envelope-from <schwarze@usta.de>)
	id 1OGNLb-0007Xd-Hi
	for tech@mdocml.bsd.lv; Mon, 24 May 2010 04:24:55 +0200
Received: from schwarze by usta.de with local (Exim 4.71)
	(envelope-from <schwarze@usta.de>)
	id 1OGNLb-0002HX-H0
	for tech@mdocml.bsd.lv; Mon, 24 May 2010 04:24:55 +0200
Date: Mon, 24 May 2010 04:24:55 +0200
From: Ingo Schwarze <schwarze@usta.de>
To: tech@mdocml.bsd.lv
Subject: Re: .Bl and .Pp
Message-ID: <20100524022455.GE14709@iris.usta.de>
References: <20100517220042.GA21819@britannica.bec.de>
 <4BF2442F.5020704@bsd.lv>
 <20100523001413.GA1698@britannica.bec.de>
X-Mailinglist: mdocml-tech
Reply-To: tech@mdocml.bsd.lv
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100523001413.GA1698@britannica.bec.de>
User-Agent: Mutt/1.5.20 (2009-06-14)

Hi Joerg,

Joerg Sonnenberger wrote on Sun, May 23, 2010 at 02:14:14AM +0200:
> On Tue, May 18, 2010 at 09:39:27AM +0200, Kristaps Dzonsons wrote:
>> Someone wrote:

>>> The file also shows another issue.
>>>
>>> .Bl -tag -compact
>>> .Sm off
>>> .It ...
>>> .Sm on
>>> .El
>>>
>>> triggers the assertion in mdoc_action.c:618 (post_bl_tagwidth).
>>>
>>> I think we have to explicitly scan forward until we find an .It child,
>>> but what do you think?

>> Will look into it...

> Patch attached. Skip over non-It macros for this purpose.

This is
  OK schwarze@

and also tested and committed in the OpenBSD tree.

Yours,
  Ingo


> Index: mdoc_action.c
> ===================================================================
> RCS file: /home/joerg/cvsroot/mdocml/mdoc_action.c,v
> retrieving revision 1.60
> diff -u -p -r1.60 mdoc_action.c
> --- mdoc_action.c	17 May 2010 23:57:06 -0000	1.60
> +++ mdoc_action.c	23 May 2010 00:07:11 -0000
> @@ -637,11 +637,14 @@ post_bl_tagwidth(POST_ARGS)
>  	/* Defaults to ten ens. */
>  
>  	sz = 10; /* XXX: make this a macro value. */
> -	nn = n->body->child;
> +
> +	for (nn = n->body->child; nn; nn = nn->next) {
> +		if (MDOC_It == nn->tok)
> +			break;
> +	}
>  
>  	if (nn) {
>  		assert(MDOC_BLOCK == nn->type);
> -		assert(MDOC_It == nn->tok);
>  		nn = nn->head->child;
>  		if (MDOC_TEXT != nn->type) {
>  			sz = mdoc_macro2len(nn->tok);
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv