From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from acme.spoerlein.net (acme.spoerlein.net [188.72.220.29]) by krisdoz.my.domain (8.14.3/8.14.3) with ESMTP id o5EHaN3o015660 for ; Mon, 14 Jun 2010 13:36:24 -0400 (EDT) Received: from acme.spoerlein.net (localhost.spoerlein.net [IPv6:::1]) by acme.spoerlein.net (8.14.4/8.14.4) with ESMTP id o5EHaNCV062366 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 14 Jun 2010 19:36:23 +0200 (CEST) (envelope-from uqs@spoerlein.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=spoerlein.net; s=dkim200908; t=1276536983; bh=NbF+M/xtfdk7XnFpLIbOfO8FWfkmokBpnDR9SgU9j1o=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Transfer-Encoding:In-Reply-To; b=u20lGxm1sB2no55Uy7ogzIcqhGi/Cgry3WPIoFsHB/FH3cT5tWxUr8UC0f17onalW Zt+aCBZgfSk6m6O7o/VmM02H8Aq6hAI8Hr+bEcLuyBRJbOxx3832vyuEm8onjc0Ga4 VgC87aJ+qilM1kKQzuUfggU498aFi+pTzyF+fjPg= Received: (from uqs@localhost) by acme.spoerlein.net (8.14.4/8.14.4/Submit) id o5EHaNAv062365 for tech@mdocml.bsd.lv; Mon, 14 Jun 2010 19:36:23 +0200 (CEST) (envelope-from uqs@spoerlein.net) Date: Mon, 14 Jun 2010 19:36:23 +0200 From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= To: tech@mdocml.bsd.lv Subject: Re: Reducing uname footer string on FreeBSD Message-ID: <20100614173623.GF3632@acme.spoerlein.net> References: <20100609163447.GA39829@acme.spoerlein.net> <20100612171844.GE6086@iris.usta.de> <4C153267.5080904@bsd.lv> X-Mailinglist: mdocml-tech Reply-To: tech@mdocml.bsd.lv MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4C153267.5080904@bsd.lv> User-Agent: Mutt/1.5.20 (2009-06-14) On Sun, 13.06.2010 at 21:32:55 +0200, Kristaps Džonsons wrote: > >> The attached patch clamps the string after the dash, iff uname reports > >> we are running on FreeBSD. I don't think such special casing should be > >> applied in the general source tree, but wanted to put it up for > >> discussion anyway. > > > > Actually, i wouldn't even object to this particular patch going in > > in case that's easier for you. After all, > > > > - post_os() is typically called once per input file; > > - this is the central place where OS names are handled, > > so having differences here is not that surprising; > > - your patch is not expensive: linear in the length > > of the string "FreeBSD" on FreeBSD, one return-at-once > > function call everywhere else. > > > > So, even if all the four major free BSD implementations would > > need something like this in post_os(), it would still seem > > reasonable to me. > > Ulrich and Ingo, I have no objection to this being merged so long as you > (Ulrich) can guarantee that this behaviour is general, i.e., that this > will not cause badness in any sort of FreeBSD configuration. I cannot think of any badness that this could trigger. groff(1) on FreeBSD has been doing this for a very long time. I will double check and commit if everything checks out. Uli -- To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv