From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp1.rz.uni-karlsruhe.de (Debian-exim@smtp1.rz.uni-karlsruhe.de [129.13.185.217])
	by krisdoz.my.domain (8.14.3/8.14.3) with ESMTP id o5QDrKIT021986
	for <tech@mdocml.bsd.lv>; Sat, 26 Jun 2010 09:53:21 -0400 (EDT)
Received: from hekate.usta.de (asta-nat.asta.uni-karlsruhe.de [172.22.63.82])
	by smtp1.rz.uni-karlsruhe.de with esmtp (Exim 4.63 #1)
	id 1OSVot-0002XO-VG; Sat, 26 Jun 2010 15:53:20 +0200
Received: from donnerwolke.usta.de ([172.24.96.3])
	by hekate.usta.de with esmtp (Exim 4.71)
	(envelope-from <schwarze@usta.de>)
	id 1OSVot-0002KV-U2
	for tech@mdocml.bsd.lv; Sat, 26 Jun 2010 15:53:19 +0200
Received: from iris.usta.de ([172.24.96.5] helo=usta.de)
	by donnerwolke.usta.de with esmtp (Exim 4.69)
	(envelope-from <schwarze@usta.de>)
	id 1OSVot-000580-TG
	for tech@mdocml.bsd.lv; Sat, 26 Jun 2010 15:53:19 +0200
Received: from schwarze by usta.de with local (Exim 4.71)
	(envelope-from <schwarze@usta.de>)
	id 1OSVot-0003jD-SV
	for tech@mdocml.bsd.lv; Sat, 26 Jun 2010 15:53:19 +0200
Date: Sat, 26 Jun 2010 15:53:19 +0200
From: Ingo Schwarze <schwarze@usta.de>
To: tech@mdocml.bsd.lv
Subject: Re: [PATCH] implement .Bk
Message-ID: <20100626135319.GD22002@iris.usta.de>
References: <20100626133824.GB22002@iris.usta.de>
 <4C2606A4.8050203@bsd.lv>
X-Mailinglist: mdocml-tech
Reply-To: tech@mdocml.bsd.lv
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C2606A4.8050203@bsd.lv>
User-Agent: Mutt/1.5.20 (2009-06-14)

Hi Kristaps,

> I like it with one nit noted in-line.

Good, thanks for looking!

> Also, can you document this in mdoc.7?

Sure.

> In general, I try to have the "else" not have braces---most of the code
> is structured as such.  Can you flip this to
> 
>   if ( ! (TERMP_KEEP & p->flags)) {
>      multi-line
>   } else
>      buffer(p, ASCII_NBRSP);

Yes, no problem, consistent style is helpful.

Myself, i do not really like

  unless( condition ){
    do something;
  } else {
    do something else;
  }

in Perl, but perhaps "if (!) else" in C is not that bad.

Anyway, i will merge bsd.lv HEAD to OpenBSD, then apply your
points and commit to both trees.

Yours,
  Ingo
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv