From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp1.rz.uni-karlsruhe.de (Debian-exim@smtp1.rz.uni-karlsruhe.de [129.13.185.217]) by krisdoz.my.domain (8.14.3/8.14.3) with ESMTP id oB1LSa1a013826 for ; Wed, 1 Dec 2010 16:28:39 -0500 (EST) Received: from hekate.usta.de (asta-nat.asta.uni-karlsruhe.de [172.22.63.82]) by smtp1.rz.uni-karlsruhe.de with esmtp (Exim 4.63 #1) id 1PNuE6-0003xx-Qn; Wed, 01 Dec 2010 22:28:34 +0100 Received: from donnerwolke.usta.de ([172.24.96.3]) by hekate.usta.de with esmtp (Exim 4.72) (envelope-from ) id 1PNuE6-0000Xr-Pr for tech@mdocml.bsd.lv; Wed, 01 Dec 2010 22:28:34 +0100 Received: from iris.usta.de ([172.24.96.5] helo=usta.de) by donnerwolke.usta.de with esmtp (Exim 4.69) (envelope-from ) id 1PNuE6-0005Ty-OY for tech@mdocml.bsd.lv; Wed, 01 Dec 2010 22:28:34 +0100 Received: from schwarze by usta.de with local (Exim 4.72) (envelope-from ) id 1PNuE6-0007bL-Gf for tech@mdocml.bsd.lv; Wed, 01 Dec 2010 22:28:34 +0100 Date: Wed, 1 Dec 2010 22:28:34 +0100 From: Ingo Schwarze To: tech@mdocml.bsd.lv Subject: Re: exit_status persistence. Message-ID: <20101201212834.GA22990@iris.usta.de> References: <4CF678F0.6020304@bsd.lv> X-Mailinglist: mdocml-tech Reply-To: tech@mdocml.bsd.lv MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CF678F0.6020304@bsd.lv> User-Agent: Mutt/1.5.21 (2010-09-15) Hi Kristaps, Kristaps Dzonsons wrote on Wed, Dec 01, 2010 at 05:33:52PM +0100: > Ingo, I flushed out some peculiar behaviour in the new main.c. > > If a FATAL parse error occurs (e.g., rxdebug.1) when multiple files > are passed on the command-line, subsequent files are parsed but not > outputted. This occurs due to main.c:484. I don't want to monkey > with exit_status---can you verify that exit_status may somehow be > saved or reset between parses so that passing multiple files doesn't > cause truncated output? Looking at the code, i'd say you are right, this looks like a blatant design error and needs to be fixed. I'll probably split exit_status into two variables: First, file_status will be initialized to MANDOCERR_OK for each file, and that's the one mmsg will write to. Then, at the end of each file, the contents must be moved to exit_status, in case it's more severe than what is already there. I'll cook up a patch after completing the bsd.lv -> OpenBSD merges. Merge, then write code is usually better than the other way round. :) Yours, Ingo -- To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv