Re: [PATCH] partial cleanup of mdoc(7) arg count validation

[Ingo Schwarze <schwarze@usta.de>]

Hi Kristaps,

> These look fine by me, as the ERROR->WARN downgrade doesn't effect a
> semantic difference.

Thanks, these are in.

> In general I encourage two functions instead of one (e.g., checking
> whether an argument exist (1) and checking whether it's bool (2)) to
> avoid code duplication.  If your way doesn't bloat the code any,
> however, I'm not opposed to it.

No, it doesn't bloat.

With two functions, we typically have:
 * an entry in the function table
 * an xwarn_opN() wrapper function
 * that one just calls check_count() and returns (one line)
 * the main post_macro() validator function

With one function (in the cases where i removed the second
function), we have:
 * one fewer entry in the function table
 * sometimes the wrapper could be deleted completely
 * one additional line to call check_count() from post_macro()

What would bloat the code would be to introduce a new post_macro()
function just to call check_count() a few times, but i didn't
do that.

Yours,
  Ingo
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv