Re: Improved handling of literals in -man.

[Ingo Schwarze <schwarze@usta.de>]

Hi Kristaps,

Kristaps Dzonsons wrote on Fri, Jul 08, 2011 at 03:10:28PM +0200:

> Enclosed is a patch that considerably simplifies and improves the
> handling of literals in -man.

Err, no.
It considerably breaks literal handling and removes functionality.

Here is a (possibly partial) list of what breaks:

  /usr/src/regress/usr.bin/mandoc/man/nf/indent
    - Long lines now wrap even in literal mode.

  /usr/src/regress/usr.bin/mandoc/man/nf/indent
  /usr/src/regress/usr.bin/mandoc/man/nf/args
  /usr/src/regress/usr.bin/mandoc/man/IP/literal
  /usr/src/regress/usr.bin/mandoc/man/TP/literal
    - Regular text right after .fi ends up one the same line
      as the last line of the text in the literal block.

  c2ph(1):
    - Lines containing nothing but "\&" get lost.

Actually, there is also one thing this seems to fix:

  .ft B
  .nf
  some text
  .fi
  .ft P

That's supposed to produce bold literal text, which currently mandoc
does not do.  See cvs(1) for an example, search for "1 month ago".

At the end of the day, this patch causes so much noise that i'm
giving up on doing a full regression report.  I don't really feel
like reading through a 150 thousand line diff right now.  :-o

Yours,
  Ingo


P.S.
Here you are testing the same condition twice:

> +		if ( ! (MANT_LITERAL & mt->fl)) {
> +			if (' ' == *n->string && MAN_LINE & n->flags)
> +				term_newln(p);
> +		} else if (MANT_LITERAL & mt->fl)
> +			if (n->prev && n->prev->line != n->line)
> +				term_newln(p);

Looks like:  if (!foo) ...; else if (foo) ...
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv