From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from scc-mailout.scc.kit.edu (scc-mailout.scc.kit.edu [129.13.185.202])
	by krisdoz.my.domain (8.14.3/8.14.3) with ESMTP id p8KCERV8009998
	for <tech@mdocml.bsd.lv>; Tue, 20 Sep 2011 08:14:28 -0400 (EDT)
Received: from hekate.usta.de (asta-nat.asta.uni-karlsruhe.de [172.22.63.82])
	by scc-mailout-02.scc.kit.edu with esmtp (Exim 4.72 #1)
	id 1R5zDN-00081W-Tb; Tue, 20 Sep 2011 14:14:17 +0200
Received: from donnerwolke.usta.de ([172.24.96.3])
	by hekate.usta.de with esmtp (Exim 4.72)
	(envelope-from <schwarze@usta.de>)
	id 1R5zDW-0007Ut-LN
	for tech@mdocml.bsd.lv; Tue, 20 Sep 2011 14:14:26 +0200
Received: from iris.usta.de ([172.24.96.5] helo=usta.de)
	by donnerwolke.usta.de with esmtp (Exim 4.69)
	(envelope-from <schwarze@usta.de>)
	id 1R5zDW-0004Q5-JY
	for tech@mdocml.bsd.lv; Tue, 20 Sep 2011 14:14:26 +0200
Received: from schwarze by usta.de with local (Exim 4.72)
	(envelope-from <schwarze@usta.de>)
	id 1R5zDW-0000Mn-LJ
	for tech@mdocml.bsd.lv; Tue, 20 Sep 2011 14:14:26 +0200
Date: Tue, 20 Sep 2011 14:14:26 +0200
From: Ingo Schwarze <schwarze@usta.de>
To: tech@mdocml.bsd.lv
Subject: Re: TERMP_NOLPAD r.i.p.
Message-ID: <20110920121426.GB13269@iris.usta.de>
References: <20110918161317.GE29692@iris.usta.de>
 <4E765AFE.9070302@bsd.lv>
 <20110919213939.GA19736@iris.usta.de>
 <4E77BB0F.4060602@bsd.lv>
 <4E78751D.6040700@bsd.lv>
X-Mailinglist: mdocml-tech
Reply-To: tech@mdocml.bsd.lv
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E78751D.6040700@bsd.lv>
User-Agent: Mutt/1.5.21 (2010-09-15)

Hi Kristaps,

Kristaps Dzonsons wrote on Tue, Sep 20, 2011 at 01:12:29PM +0200:

> This last checkin raised an assertion failure when run over NetBSD's
> manuals.  One can reproduce the failure as follows (cut from
> slapo-retcode.5):
> 
> .TH SLAPO-RETCODE 5 "2010/06/30" "OpenLDAP 2.4.23"
> .SH NAME
> slapo\-retcode \- return code overlay to slapd
> .SH DESCRIPTION
> This directive defines the parent DN where dynamically generated
> entries reside.
> If not defined, the suffix of the database is used.
> .HP
> .hy 0
> .B retcode\-item <RDN> <errCode> [op=<oplist>] [text=<message>]
> .B [ref=<referral>] [sleeptime=<sec>] [matched=<DN>]
> .B [unsolicited=<OID>[:<data>]] [flags=[{pre|post}\-]disconnect[,...]]
> .RS
> A dynamically generated entry, located below \fBretcode\-parent\fP.

Looks like that is an unrelated bug in pre_RS, merely uncovered
by the changes.  When changing the output offset, .RS neglects
to reset the right margin to the default, and it also neglects
to check whether the offset fits into the margin.

The following fixes the (ugly!) test page, and i see no
regressions.

OK?
  Ingo


Index: man_term.c
===================================================================
RCS file: /cvs/src/usr.bin/mandoc/man_term.c,v
retrieving revision 1.73
diff -u -p -r1.73 man_term.c
--- man_term.c	20 Sep 2011 09:02:18 -0000	1.73
+++ man_term.c	20 Sep 2011 12:04:15 -0000
@@ -822,7 +822,8 @@ pre_RS(DECL_ARGS)
 			sz = (size_t)ival;
 
 	mt->offset += sz;
-	p->offset = mt->offset;
+	p->rmargin = p->maxrmargin;
+	p->offset = mt->offset < p->rmargin ? mt->offset : p->rmargin;
 
 	if (++mt->lmarginsz < MAXMARGINS)
 		mt->lmargincur = mt->lmarginsz;
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv