Re: TERMP_NOLPAD r.i.p.

[Ingo Schwarze <schwarze@usta.de>]

Hi Kristaps,

Kristaps Dzonsons wrote on Tue, Sep 20, 2011 at 02:26:16PM +0200:

> That indeed fixes it!  But another takes its place... The relevant
> file is enclosed.

I have no idea why this pops up only now, but let's fix it
anyway.

The problem is that groff_hdtbl(7) is doing something like

  .de OUCH
  .TP
  .BI
  ..
  .OUCH

tricking the .TP macro and its *next-line* head argument
onto the *same* input line.  So .TP is not allowed to assume
that a head argument being on the same line is indeed a same-line
argument.

I don't see any other similar case in this source file,
and i don't see any regressions.

OK?
  Ingo


P.S.:
Of course, the fix only fixes the segfault.
This raises a more serious question:
In the view of macros, our use of the source line
for semantic purposes is fundamentally broken.
We do that at several places.

P.P.S.:
Mandoc is definitely not the right tool to process groff_hdtbl(7),
but at least it shouldn't segfault.


Index: man_term.c
===================================================================
RCS file: /cvs/src/usr.bin/mandoc/man_term.c,v
retrieving revision 1.74
diff -u -p -r1.74 man_term.c
--- man_term.c	20 Sep 2011 13:13:21 -0000	1.74
+++ man_term.c	20 Sep 2011 13:16:41 -0000
@@ -636,7 +636,7 @@ pre_TP(DECL_ARGS)
 	/* Calculate offset. */
 
 	if (NULL != (nn = n->parent->head->child))
-		if (nn->parent->line == nn->line)
+		if (nn->string && nn->parent->line == nn->line)
 			if ((ival = a2width(p, nn->string)) >= 0)
 				len = (size_t)ival;
 
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv